Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1645913002: Add additive animation support for CSS property motion-rotation (Closed)

Created:
4 years, 11 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_propertyInterpolationTypesMapping
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add additive animation support for CSS property motion-rotation This patch adds support for composite modes on motion-rotation CSS animations via element.animate(). BUG=437696 Committed: https://crrev.com/71ac8aaf1a1b23909c813922b2e5a606d4442b7c Cr-Commit-Position: refs/heads/master@{#376149}

Patch Set 1 #

Patch Set 2 : Factor StyleMotionRotation change out #

Patch Set 3 : Add tests pending rebaselining #

Patch Set 4 : Rebased #

Patch Set 5 : Rebaseline test #

Patch Set 6 : Rebased #

Patch Set 7 : Rebased #

Messages

Total messages: 20 (9 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2016-02-05 02:32:51 UTC) #3
Eric Willigers
lgtm
4 years, 10 months ago (2016-02-05 03:25:56 UTC) #4
alancutter (OOO until 2018)
+dstockwell for core.gypi changes.
4 years, 10 months ago (2016-02-17 05:47:53 UTC) #5
dstockwell
lgtm
4 years, 10 months ago (2016-02-18 03:00:04 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645913002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645913002/100001
4 years, 10 months ago (2016-02-18 04:42:42 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/132434) ios_rel_device_ninja on ...
4 years, 10 months ago (2016-02-18 04:45:37 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645913002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645913002/120001
4 years, 10 months ago (2016-02-18 06:48:39 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 07:51:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645913002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645913002/120001
4 years, 10 months ago (2016-02-18 12:25:41 UTC) #17
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 10 months ago (2016-02-18 12:35:38 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 12:36:43 UTC) #20
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/71ac8aaf1a1b23909c813922b2e5a606d4442b7c
Cr-Commit-Position: refs/heads/master@{#376149}

Powered by Google App Engine
This is Rietveld 408576698