Add additive animation support for CSS property clip

Add additive animation support for CSS property clip

This patch adds support for composite modes on clip CSS animations
via element.animate().

This also changes clip to be more strict about when it permits smooth
interpolation between values.
Previously "rect(100px, auto, auto, auto)" would smoothly interpolate
with "rect(200px, 100px, auto, auto)". Now these values will 50% flip
as their distribution of auto keywords do not line up. This behaviour
matches Firefox.

BUG=437696
Committed: https://crrev.com/3106ad7791c2a9bc05d0a38384dafb9f9342986c
Cr-Commit-Position: refs/heads/master@{#376115}

[alancutter (OOO until 2018), 2016-01-27 05:38:56]

Description was changed from

==========
Add composited animation support for CSS property clip

This patch adds support for composite modes on clip CSS animations
via element.animate().

This also changes clip to be more strict about when it permits smooth
interpolation between values.
Previously "rect(100px, auto, auto, auto)" would smoothly interpolate
with "rect(200px, 100px, auto, auto)". Now these values will 50% flip
as their distribution of auto keywords do not line up.

BUG=437696
==========

to

==========
Add composited animation support for CSS property clip

This patch adds support for composite modes on clip CSS animations
via element.animate().

This also changes clip to be more strict about when it permits smooth
interpolation between values.
Previously "rect(100px, auto, auto, auto)" would smoothly interpolate
with "rect(200px, 100px, auto, auto)". Now these values will 50% flip
as their distribution of auto keywords do not line up. This behaviour
matches Firefox.

BUG=437696
==========

[alancutter (OOO until 2018), 2016-01-27 05:38:56]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org

[alancutter (OOO until 2018), 2016-01-28 00:00:02]

Description was changed from

==========
Add composited animation support for CSS property clip

This patch adds support for composite modes on clip CSS animations
via element.animate().

This also changes clip to be more strict about when it permits smooth
interpolation between values.
Previously "rect(100px, auto, auto, auto)" would smoothly interpolate
with "rect(200px, 100px, auto, auto)". Now these values will 50% flip
as their distribution of auto keywords do not line up. This behaviour
matches Firefox.

BUG=437696
==========

to

==========
Add additive animation support for CSS property clip

This patch adds support for composite modes on clip CSS animations
via element.animate().

This also changes clip to be more strict about when it permits smooth
interpolation between values.
Previously "rect(100px, auto, auto, auto)" would smoothly interpolate
with "rect(200px, 100px, auto, auto)". Now these values will 50% flip
as their distribution of auto keywords do not line up. This behaviour
matches Firefox.

BUG=437696
==========

[alancutter (OOO until 2018), 2016-02-17 05:56:50]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[alancutter (OOO until 2018), 2016-02-17 05:56:50]

+ericwilligers for core/animation changes.

[Eric Willigers, 2016-02-17 12:09:53]

lgtm

https://codereview.chromium.org/1640643002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/animations/composition/clip-composition.html
(right):

https://codereview.chromium.org/1640643002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/composition/clip-composition.html:7:
underlying: 'rect(50px 50px 50px 50px)',
Can we have these 12 values be distinct?
e.g.

  0  10  20  30
140 230 320 410
180 270 360 450

https://codereview.chromium.org/1640643002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
(right):

https://codereview.chromium.org/1640643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp:28:
ClipAutos(const LengthBox& clip)
Perhaps this can be explicit.

[alancutter (OOO until 2018), 2016-02-17 23:44:34]

+dstockwell for core.gypi changes.

https://codereview.chromium.org/1640643002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/animations/composition/clip-composition.html
(right):

https://codereview.chromium.org/1640643002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/composition/clip-composition.html:7:
underlying: 'rect(50px 50px 50px 50px)',
On 2016/02/17 at 12:09:53, Eric Willigers wrote:
> Can we have these 12 values be distinct?
> e.g.
> 
>   0  10  20  30
> 140 230 320 410
> 180 270 360 450

Done.

https://codereview.chromium.org/1640643002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
(right):

https://codereview.chromium.org/1640643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp:28:
ClipAutos(const LengthBox& clip)
On 2016/02/17 at 12:09:53, Eric Willigers wrote:
> Perhaps this can be explicit.

Done.

[dstockwell, 2016-02-18 02:58:43]

lgtm

[alancutter (OOO until 2018), 2016-02-18 03:56:42]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-02-18 03:56:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/1640643002/#ps40001
(title: "Review changes")

[commit-bot: I haz the power, 2016-02-18 03:57:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640643002/40001

[commit-bot: I haz the power, 2016-02-18 04:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 04:36:14]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2016-02-18 06:00:14]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-02-18 06:00:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/1640643002/#ps60001
(title: "Fix up existing tests")

[commit-bot: I haz the power, 2016-02-18 06:00:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640643002/60001

[commit-bot: I haz the power, 2016-02-18 06:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 06:03:50]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2016-02-18 06:05:02]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-02-18 06:05:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/1640643002/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2016-02-18 06:05:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640643002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640643002/80001

[commit-bot: I haz the power, 2016-02-18 07:36:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-18 07:38:09]

Description was changed from

==========
Add additive animation support for CSS property clip

This patch adds support for composite modes on clip CSS animations
via element.animate().

This also changes clip to be more strict about when it permits smooth
interpolation between values.
Previously "rect(100px, auto, auto, auto)" would smoothly interpolate
with "rect(200px, 100px, auto, auto)". Now these values will 50% flip
as their distribution of auto keywords do not line up. This behaviour
matches Firefox.

BUG=437696
==========

to

==========
Add additive animation support for CSS property clip

This patch adds support for composite modes on clip CSS animations
via element.animate().

This also changes clip to be more strict about when it permits smooth
interpolation between values.
Previously "rect(100px, auto, auto, auto)" would smoothly interpolate
with "rect(200px, 100px, auto, auto)". Now these values will 50% flip
as their distribution of auto keywords do not line up. This behaviour
matches Firefox.

BUG=437696

Committed: https://crrev.com/3106ad7791c2a9bc05d0a38384dafb9f9342986c
Cr-Commit-Position: refs/heads/master@{#376115}
==========

[commit-bot: I haz the power, 2016-02-18 07:38:09]

Patchset 5 (id:??) landed as
https://crrev.com/3106ad7791c2a9bc05d0a38384dafb9f9342986c
Cr-Commit-Position: refs/heads/master@{#376115}