Issue 164573002: Revert 251003 "Revert 250830 "Exclude notification strings for b..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164573002: Revert 251003 "Revert 250830 "Exclude notification strings for b..." (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)

Modified:
6 years, 10 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 251003 "Revert 250830 "Exclude notification strings for b..." > Revert 250830 "Exclude notification strings for builds that dont..." > > > Exclude notification strings for builds that dont use it. > > > > BUG=326023 > > > > Review URL: https://codereview.chromium.org/160113002 > > Broke win64 sync tests, e.g. output: > > c:\b\build\slave\cr-win-rel-x64\build\src\chrome\browser\sync\test\integration\sync_test.cc(707): error: Value of: UTF16ToASCII(browser()->tab_strip_model()->GetActiveWebContents()-> GetTitle()) > Actual: "" > Expected: "Notifications enabled" > > TBR=aurimas@chromium.org > > Review URL: https://codereview.chromium.org/163713002 Reverting the revert, since this wasn't responsible for the failures. TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251106

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -73 lines)			Patch
	M	trunk/src/build/common.gypi	View		3 chunks	+6 lines, -4 lines	0 comments	Download
	M	trunk/src/chrome/app/generated_resources.grd	View		1 chunk	+71 lines, -69 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexei Svitkine (slow)

6 years, 10 months ago (2014-02-13 20:14:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r251106.

Expand Messages | Collapse Messages