Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 160113002: Exclude notification strings for builds that dont use it. (Closed)

Created:
6 years, 10 months ago by aurimas (slooooooooow)
Modified:
6 years, 10 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude notification strings for builds that dont use it. BUG=326023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250830

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -73 lines) Patch
M build/common.gypi View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +71 lines, -69 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
aurimas (slooooooooow)
Hey Newton, Please take a look at this change. Thanks, Aurimas
6 years, 10 months ago (2014-02-11 23:02:36 UTC) #1
newt (away)
lgtm https://codereview.chromium.org/160113002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/160113002/diff/1/chrome/app/generated_resources.grd#newcode12898 chrome/app/generated_resources.grd:12898: + <if expr="enable_notifications"> what lovely expression syntax! :)
6 years, 10 months ago (2014-02-12 18:39:59 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-12 18:41:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/160113002/1
6 years, 10 months ago (2014-02-12 18:44:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 20:49:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262639
6 years, 10 months ago (2014-02-12 20:49:38 UTC) #6
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-12 21:23:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/160113002/1
6 years, 10 months ago (2014-02-12 21:24:41 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 23:18:08 UTC) #9
Message was sent while issue was closed.
Change committed as 250830

Powered by Google App Engine
This is Rietveld 408576698