Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163713002: Revert 250830 "Exclude notification strings for builds that dont..." (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 250830 "Exclude notification strings for builds that dont..." > Exclude notification strings for builds that dont use it. > > BUG=326023 > > Review URL: https://codereview.chromium.org/160113002 Broke win64 sync tests, e.g. output: c:\b\build\slave\cr-win-rel-x64\build\src\chrome\browser\sync\test\integration\sync_test.cc(707): error: Value of: UTF16ToASCII(browser()->tab_strip_model()->GetActiveWebContents()-> GetTitle()) Actual: "" Expected: "Notifications enabled" TBR=aurimas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -77 lines) Patch
M trunk/src/build/common.gypi View 3 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/chrome/app/generated_resources.grd View 1 chunk +69 lines, -71 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
6 years, 10 months ago (2014-02-13 14:54:36 UTC) #1
Alexei Svitkine (slow)
Committed patchset #1 manually as r251003.
6 years, 10 months ago (2014-02-13 14:54:48 UTC) #2
Alexei Svitkine (slow)
tests that failed: 1. sync_integration_tests<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests> sync_integration_tests 20 disabled failed 33 ( 9 mins, 28 secs ...
6 years, 10 months ago (2014-02-13 14:58:03 UTC) #3
Alexei Svitkine (slow)
6 years, 10 months ago (2014-02-13 19:06:23 UTC) #4 
Looks like this wasn't the cause. Will revert the revert once tree is green.


On Thu, Feb 13, 2014 at 9:57 AM, Alexei Svitkine <asvitkine@chromium.org>wrote:

> tests that failed:
>
>
>    1.
sync_integration_tests<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests>
sync_integration_tests
>    20 disabled failed 33 ( 9 mins, 28 secs )
>    1.
stdio<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/stdio>
>       2.
DisableOneAtATime<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/DisableOneAtATime>
>       3.
EnableOneAtATime<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/EnableOneAtATime>
>       4.
AllTypesAtOnce<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/AllTypesAtOnce>
>       5.
AllTypesAtOnceTriggerNotification<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/AllTypesAtOnceTriggerNotification>
>       6.
AllTypesIndividually<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/AllTypesIndividually>
>       7.
AllTypesIndividuallyTriggerNotification<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/AllTypesIndividuallyTriggerNotification>
>       8.
AllTypesWithNigoriAtOnce<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/AllTypesWithNigoriAtOnce>
>       9.
BookmarksPrefsBoth<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/BookmarksPrefsBoth>
>       10.
BookmarksPrefsIndividually<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/BookmarksPrefsIndividually>
>       11.
NigoriOnly<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/NigoriOnly>
>       12.
PrefsNigoriBoth<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/PrefsNigoriBoth>
>       13.
PrefsOnlyModifyBookmark<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/PrefsOnlyModifyBookmark>
>       14.
PrefsOnlyModifyPref<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/PrefsOnlyModifyPref>
>       15.
PrefsOnlyTriggerNotification<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/PrefsOnlyTriggerNotification>
>       16.
MigratePrefsAndBookmarksThenModifyBookmark<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/MigratePrefsAndBookmarksThenModifyBookmark>
>       17.
MigratePrefsThenModifyBookmark<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/MigratePrefsThenModifyBookmark>
>       18.
ResponseCodeIsPreserved<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/ResponseCodeIsPreserved>
>       19.
TimestampMatchesHistory<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/TimestampMatchesHistory>
>       20.
InvalidClient<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/InvalidClient>
>       21.
InvalidGrant<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/InvalidGrant>
>       22.
RequestCanceled<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/RequestCanceled>
>       23.
RetryOnHttpForbidden403<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/RetryOnHttpForbidden403>
>       24.
RetryOnInternalServerError500<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/RetryOnInternalServerError500>
>       25.
RetryOnMalformedToken<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/RetryOnMalformedToken>
>       26.
RetryOnRequestFailed<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/RetryOnRequestFailed>
>       27.
TokenExpiry<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/TokenExpiry>
>       28.
ActionableErrorTest<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/ActionableErrorTest>
>       29.
BirthdayErrorTest<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/BirthdayErrorTest>
>       30.
BirthdayErrorUsingActionableErrorTest<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/BirthdayErrorUsingActionableErrorTest>
>       31.
ErrorWhileSettingUp<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/ErrorWhileSettingUp>
>       32.
OfflineToOnline<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/OfflineToOnline>
>       33.
TransientErrorTest<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/TransientErrorTest>
>       34.
CreateSyncedBookmarks<http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201/steps/sync_integration_tests/logs/CreateSyncedBookmarks>
>
>
>
> On Thu, Feb 13, 2014 at 9:54 AM, <asvitkine@chromium.org> wrote:
>
>> Committed patchset #1 manually as r251003.
>>
>> https://codereview.chromium.org/163713002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698