webkit/glue/webframe_unittest.cc - Issue 164565: Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webframe_unittest.cc

Issue 164565: Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/webframe_unittest.cc

===================================================================

--- webkit/glue/webframe_unittest.cc (revision 23431)

+++ webkit/glue/webframe_unittest.cc (working copy)

@@ -85,9 +85,9 @@

// Test selection check

EXPECT_FALSE(frame->hasSelection());

- frame->selectAll();

+ frame->executeCommand(WebString::fromUTF8("SelectAll"));

EXPECT_TRUE(frame->hasSelection());

- frame->clearSelection();

+ frame->executeCommand(WebString::fromUTF8("Unselect"));

EXPECT_FALSE(frame->hasSelection());

WebString selection_html = frame->selectionAsMarkup();

EXPECT_TRUE(selection_html.isEmpty());

« no previous file with comments | « webkit/glue/webframe_impl.cc ('k') | webkit/glue/webview_impl.cc » ('j') | no next file with comments »