Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1645643002: Replace isAppropriateFor with suitabilityFor and start using it (Closed)

Created:
4 years, 11 months ago by Brian Wilkerson
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace isAppropriateFor with suitabilityFor and start using it R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a1feb55137dbcca2f8d4a97b69a5437e4826ca60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -41 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +17 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 3 chunks +15 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/html.dart View 2 chunks +16 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/manager.dart View 2 chunks +15 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/task/model.dart View 3 chunks +11 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 2 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/yaml.dart View 4 chunks +14 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 4 chunks +12 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/task/yaml.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/model_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/yaml_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 11 months ago (2016-01-27 17:09:55 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-27 17:24:11 UTC) #3
Brian Wilkerson
4 years, 11 months ago (2016-01-27 17:26:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a1feb55137dbcca2f8d4a97b69a5437e4826ca60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698