Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: pkg/analyzer/test/src/task/model_test.dart

Issue 1645643002: Replace isAppropriateFor with suitabilityFor and start using it (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analyzer/lib/task/yaml.dart ('k') | pkg/analyzer/test/src/task/yaml_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.test.src.task.model_test; 5 library analyzer.test.src.task.model_test;
6 6
7 import 'package:analyzer/src/generated/engine.dart'; 7 import 'package:analyzer/src/generated/engine.dart';
8 import 'package:analyzer/src/generated/java_engine.dart'; 8 import 'package:analyzer/src/generated/java_engine.dart';
9 import 'package:analyzer/src/task/model.dart'; 9 import 'package:analyzer/src/task/model.dart';
10 import 'package:analyzer/task/model.dart'; 10 import 'package:analyzer/task/model.dart';
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 String name = 'name'; 107 String name = 'name';
108 BuildTask buildTask = (context, target) {}; 108 BuildTask buildTask = (context, target) {};
109 CreateTaskInputs createTaskInputs = (target) {}; 109 CreateTaskInputs createTaskInputs = (target) {};
110 List<ResultDescriptor> results = <ResultDescriptor>[]; 110 List<ResultDescriptor> results = <ResultDescriptor>[];
111 TaskDescriptorImpl descriptor = 111 TaskDescriptorImpl descriptor =
112 new TaskDescriptorImpl(name, buildTask, createTaskInputs, results); 112 new TaskDescriptorImpl(name, buildTask, createTaskInputs, results);
113 expect(descriptor, isNotNull); 113 expect(descriptor, isNotNull);
114 expect(descriptor.name, name); 114 expect(descriptor.name, name);
115 expect(descriptor.buildTask, equals(buildTask)); 115 expect(descriptor.buildTask, equals(buildTask));
116 expect(descriptor.createTaskInputs, equals(createTaskInputs)); 116 expect(descriptor.createTaskInputs, equals(createTaskInputs));
117 expect(descriptor.isAppropriateFor(null), isTrue); 117 expect(descriptor.suitabilityFor(null), TaskSuitability.LOWEST);
118 expect(descriptor.results, results); 118 expect(descriptor.results, results);
119 } 119 }
120 120
121 test_create_withIsAppropriateFor() { 121 test_create_withIsAppropriateFor() {
122 String name = 'name'; 122 String name = 'name';
123 BuildTask buildTask = (context, target) {}; 123 BuildTask buildTask = (context, target) {};
124 CreateTaskInputs createTaskInputs = (target) {}; 124 CreateTaskInputs createTaskInputs = (target) {};
125 List<ResultDescriptor> results = <ResultDescriptor>[]; 125 List<ResultDescriptor> results = <ResultDescriptor>[];
126 IsAppropriateFor isAppropriateFor = (target) => false; 126 SuitabilityFor suitabilityFor = (target) => TaskSuitability.NONE;
127 TaskDescriptorImpl descriptor = new TaskDescriptorImpl( 127 TaskDescriptorImpl descriptor = new TaskDescriptorImpl(
128 name, buildTask, createTaskInputs, results, 128 name, buildTask, createTaskInputs, results,
129 isAppropriateFor: isAppropriateFor); 129 suitabilityFor: suitabilityFor);
130 expect(descriptor, isNotNull); 130 expect(descriptor, isNotNull);
131 expect(descriptor.name, name); 131 expect(descriptor.name, name);
132 expect(descriptor.buildTask, equals(buildTask)); 132 expect(descriptor.buildTask, equals(buildTask));
133 expect(descriptor.createTaskInputs, equals(createTaskInputs)); 133 expect(descriptor.createTaskInputs, equals(createTaskInputs));
134 expect(descriptor.isAppropriateFor(null), isFalse); 134 expect(descriptor.suitabilityFor(null), TaskSuitability.NONE);
135 expect(descriptor.results, results); 135 expect(descriptor.results, results);
136 } 136 }
137 137
138 test_createTask() { 138 test_createTask() {
139 BuildTask buildTask = 139 BuildTask buildTask =
140 (context, target) => new TestAnalysisTask(context, target); 140 (context, target) => new TestAnalysisTask(context, target);
141 CreateTaskInputs createTaskInputs = (target) {}; 141 CreateTaskInputs createTaskInputs = (target) {};
142 List<ResultDescriptor> results = <ResultDescriptor>[]; 142 List<ResultDescriptor> results = <ResultDescriptor>[];
143 TaskDescriptorImpl descriptor = 143 TaskDescriptorImpl descriptor =
144 new TaskDescriptorImpl('name', buildTask, createTaskInputs, results); 144 new TaskDescriptorImpl('name', buildTask, createTaskInputs, results);
145 AnalysisContext context = null; 145 AnalysisContext context = null;
146 AnalysisTarget target = new TestSource(); 146 AnalysisTarget target = new TestSource();
147 Map<String, dynamic> inputs = {}; 147 Map<String, dynamic> inputs = {};
148 AnalysisTask createTask = descriptor.createTask(context, target, inputs); 148 AnalysisTask createTask = descriptor.createTask(context, target, inputs);
149 expect(createTask, isNotNull); 149 expect(createTask, isNotNull);
150 expect(createTask.context, context); 150 expect(createTask.context, context);
151 expect(createTask.inputs, inputs); 151 expect(createTask.inputs, inputs);
152 expect(createTask.target, target); 152 expect(createTask.target, target);
153 } 153 }
154 } 154 }
OLDNEW
« no previous file with comments | « pkg/analyzer/lib/task/yaml.dart ('k') | pkg/analyzer/test/src/task/yaml_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698