Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: pkg/analyzer/test/src/task/model_test.dart

Issue 1645643002: Replace isAppropriateFor with suitabilityFor and start using it (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/task/yaml.dart ('k') | pkg/analyzer/test/src/task/yaml_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/model_test.dart
diff --git a/pkg/analyzer/test/src/task/model_test.dart b/pkg/analyzer/test/src/task/model_test.dart
index 0ea406e752d8047f5ba26738b9b2a9c83e39b90d..a798472f834aaac7e245b4b5d5171e62f5e05688 100644
--- a/pkg/analyzer/test/src/task/model_test.dart
+++ b/pkg/analyzer/test/src/task/model_test.dart
@@ -114,7 +114,7 @@ class TaskDescriptorImplTest extends EngineTestCase {
expect(descriptor.name, name);
expect(descriptor.buildTask, equals(buildTask));
expect(descriptor.createTaskInputs, equals(createTaskInputs));
- expect(descriptor.isAppropriateFor(null), isTrue);
+ expect(descriptor.suitabilityFor(null), TaskSuitability.LOWEST);
expect(descriptor.results, results);
}
@@ -123,15 +123,15 @@ class TaskDescriptorImplTest extends EngineTestCase {
BuildTask buildTask = (context, target) {};
CreateTaskInputs createTaskInputs = (target) {};
List<ResultDescriptor> results = <ResultDescriptor>[];
- IsAppropriateFor isAppropriateFor = (target) => false;
+ SuitabilityFor suitabilityFor = (target) => TaskSuitability.NONE;
TaskDescriptorImpl descriptor = new TaskDescriptorImpl(
name, buildTask, createTaskInputs, results,
- isAppropriateFor: isAppropriateFor);
+ suitabilityFor: suitabilityFor);
expect(descriptor, isNotNull);
expect(descriptor.name, name);
expect(descriptor.buildTask, equals(buildTask));
expect(descriptor.createTaskInputs, equals(createTaskInputs));
- expect(descriptor.isAppropriateFor(null), isFalse);
+ expect(descriptor.suitabilityFor(null), TaskSuitability.NONE);
expect(descriptor.results, results);
}
« no previous file with comments | « pkg/analyzer/lib/task/yaml.dart ('k') | pkg/analyzer/test/src/task/yaml_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698