Convert LayoutState/LayoutStateMaintainer/LayoutStateDisabler to references

Convert LayoutState/LayoutStateMaintainer/LayoutStateDisabler to references

Convert LayoutState/LayoutStateMaintainer/LayoutStateDisabler to references when
possible.  This is very much in the same spirit as r159391 in WebKit, but goes a
little further in converting to references where possible.  I've also taken the
opportunity to convert LayoutStateDisabler to take a RenderObject instead of the
view.  Also, FrameView gets a new RAII class to simplify code in performLayout.

BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167724

[esprehn, 2014-02-21 22:00:21]

rslgtm, references are so ugly :( *this

[atreat, 2014-02-24 16:31:50]

The CQ bit was checked by adam.treat@samsung.com

[commit-bot: I haz the power, 2014-02-24 16:31:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/164553004/1

[commit-bot: I haz the power, 2014-02-24 16:32:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-24 16:32:12]

Failed to apply patch for Source/core/rendering/RenderEmbeddedObject.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/RenderEmbeddedObject.cpp
  Hunk #1 FAILED at 234.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/rendering/RenderEmbeddedObject.cpp.rej

Patch:       Source/core/rendering/RenderEmbeddedObject.cpp
Index: Source/core/rendering/RenderEmbeddedObject.cpp
diff --git a/Source/core/rendering/RenderEmbeddedObject.cpp
b/Source/core/rendering/RenderEmbeddedObject.cpp
index
f93f9cca8003e967a4e5dd049c9f0068b2a2c82e..4da1429dd45ce6bb45bfa99aa03fa90495170e80
100644
--- a/Source/core/rendering/RenderEmbeddedObject.cpp
+++ b/Source/core/rendering/RenderEmbeddedObject.cpp
@@ -234,7 +234,7 @@ void RenderEmbeddedObject::layout()
     // When calling layout() on a child node, a parent must either push a
LayoutStateMaintainter, or
     // instantiate LayoutStateDisabler. Since using a LayoutStateMaintainer is
slightly more efficient,
     // and this method will be called many times per second during playback,
use a LayoutStateMaintainer:
-    LayoutStateMaintainer statePusher(this, locationOffset());
+    LayoutStateMaintainer statePusher(*this, locationOffset());
 
     childBox->setLocation(LayoutPoint(borderLeft(), borderTop()) +
LayoutSize(paddingLeft(), paddingTop()));
     childBox->style()->setHeight(Length(newSize.height(), Fixed));

[atreat, 2014-02-24 16:50:38]

The CQ bit was checked by adam.treat@samsung.com

[commit-bot: I haz the power, 2014-02-24 16:50:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/164553004/150001

[commit-bot: I haz the power, 2014-02-25 01:00:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/164553004/150001

[commit-bot: I haz the power, 2014-02-25 05:15:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/164553004/150001

[commit-bot: I haz the power, 2014-02-25 06:19:56]

Change committed as 167724