Source/core/rendering/RenderTableRow.cpp - Issue 164553004: Convert LayoutState/LayoutStateMaintainer/LayoutStateDisabler to references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTableRow.cpp

Issue 164553004: Convert LayoutState/LayoutStateMaintainer/LayoutStateDisabler to references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderTableRow.cpp

diff --git a/Source/core/rendering/RenderTableRow.cpp b/Source/core/rendering/RenderTableRow.cpp

index c84a1807a044d7ee31a7573d3d4481f3db60a89a..0e129aa63404fab4a93472cdd91a18fe877a9389 100644

--- a/Source/core/rendering/RenderTableRow.cpp

+++ b/Source/core/rendering/RenderTableRow.cpp

@@ -163,7 +163,7 @@ void RenderTableRow::layout()

LayoutRectRecorder recorder(*this);

// Table rows do not add translation.

- LayoutStateMaintainer statePusher(this, LayoutSize());

+ LayoutStateMaintainer statePusher(*this, LayoutSize());

bool paginated = view()->layoutState()->isPaginated();

@@ -171,7 +171,7 @@ void RenderTableRow::layout()

if (child->isTableCell()) {

SubtreeLayoutScope layouter(child);

RenderTableCell* cell = toRenderTableCell(child);

- if (!cell->needsLayout() && paginated && view()->layoutState()->pageLogicalHeight() && view()->layoutState()->pageLogicalOffset(cell, cell->logicalTop()) != cell->pageLogicalOffset())

+ if (!cell->needsLayout() && paginated && view()->layoutState()->pageLogicalHeight() && view()->layoutState()->pageLogicalOffset(*cell, cell->logicalTop()) != cell->pageLogicalOffset())

layouter.setChildNeedsLayout(cell);

if (child->needsLayout()) {

« no previous file with comments | « Source/core/rendering/RenderTable.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »