rAc - do less work when model changes

rAc - do less work when model changes

The controller now does a lot more updating/clobbering/fiddling of the view when the model changes (i.e. all the stuff right after view_->ModelChanged()). This means we can afford to do a lot less in AutofillDialogViews::ModelChanged.

Although I'm not sure of the root cause of the crash in the bug, this will also have the side effect of fixing the crash because ModelChanged is part of the stack.

Also, as a further precaution, don't de-ref a possibly NULL |instrument| (even though it does seem like it should definitely be non-NULL).

BUG=343595
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251484

[Evan Stade, 2014-02-13 20:20:43]

dbeam for review
groby for FYI (Cocoa can probably reduce the work it does in ModelChanged as
well)

[groby-ooo-7-16, 2014-02-13 21:33:06]

since modelChanged more or less mirrors what Views does, you can 

* remove   [detailsContainer_ modelChanged]; in AutofillMainContainer's
modelChanged
* remove modelChanged from autofill_details_container.{mm,h}

Or I can do that in a follow-up CL once this lands, if you'd prefer that.

[Evan Stade, 2014-02-14 03:46:53]

On 2014/02/13 21:33:06, groby wrote:
> since modelChanged more or less mirrors what Views does, you can 
> 
> * remove   [detailsContainer_ modelChanged]; in AutofillMainContainer's
> modelChanged
> * remove modelChanged from autofill_details_container.{mm,h}
> 
> Or I can do that in a follow-up CL once this lands, if you'd prefer that.

follow-up sgtm

[Dan Beam, 2014-02-14 21:19:32]

i'm not totally sure what the full repercussions of this change are, but sure
lgtm

[Evan Stade, 2014-02-14 21:42:01]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-02-14 21:46:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/164543002/150001

[commit-bot: I haz the power, 2014-02-15 03:10:54]

Change committed as 251484