Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 164543002: rAc - do less work when model changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h" 5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 1416 matching lines...) Expand 10 before | Expand all | Expand 10 after
1427 ShowDialogInMode(DETAIL_INPUT); 1427 ShowDialogInMode(DETAIL_INPUT);
1428 InvalidateLayout(); 1428 InvalidateLayout();
1429 } 1429 }
1430 DCHECK(!sign_in_web_view_->visible()); 1430 DCHECK(!sign_in_web_view_->visible());
1431 1431
1432 ContentsPreferredSizeChanged(); 1432 ContentsPreferredSizeChanged();
1433 } 1433 }
1434 1434
1435 void AutofillDialogViews::ModelChanged() { 1435 void AutofillDialogViews::ModelChanged() {
1436 menu_runner_.reset(); 1436 menu_runner_.reset();
1437
1438 for (DetailGroupMap::const_iterator iter = detail_groups_.begin();
1439 iter != detail_groups_.end(); ++iter) {
1440 UpdateDetailsGroupState(iter->second);
1441 }
1442 } 1437 }
1443 1438
1444 void AutofillDialogViews::OnSignInResize(const gfx::Size& pref_size) { 1439 void AutofillDialogViews::OnSignInResize(const gfx::Size& pref_size) {
1445 sign_in_web_view_->SetPreferredSize(pref_size); 1440 sign_in_web_view_->SetPreferredSize(pref_size);
1446 ContentsPreferredSizeChanged(); 1441 ContentsPreferredSizeChanged();
1447 } 1442 }
1448 1443
1449 void AutofillDialogViews::ValidateSection(DialogSection section) { 1444 void AutofillDialogViews::ValidateSection(DialogSection section) {
1450 ValidateGroup(*GroupForSection(section), VALIDATE_EDIT); 1445 ValidateGroup(*GroupForSection(section), VALIDATE_EDIT);
1451 } 1446 }
(...skipping 1003 matching lines...) Expand 10 before | Expand all | Expand 10 after
2455 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section) 2450 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
2456 : section(section), 2451 : section(section),
2457 container(NULL), 2452 container(NULL),
2458 manual_input(NULL), 2453 manual_input(NULL),
2459 suggested_info(NULL), 2454 suggested_info(NULL),
2460 suggested_button(NULL) {} 2455 suggested_button(NULL) {}
2461 2456
2462 AutofillDialogViews::DetailsGroup::~DetailsGroup() {} 2457 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
2463 2458
2464 } // namespace autofill 2459 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698