Issue 16453002: Removed flag optimize-constructed-arrays.

Issue 16453002: Removed flag optimize-constructed-arrays. (Closed)

Created:
7 years, 6 months ago by mvstanton

Modified:
7 years, 5 months ago

Reviewers:
Michael Starzinger, danno

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Removed flag optimize-constructed-arrays. This eliminates a large amount of hand-written assembly in the platforms. BUG= R=danno@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15328

Patch Set 3 : Rebase changes #

Total comments: 8

Patch Set 4 : Comment fixes #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+429 lines, -2520 lines)			Patch
M	src/arm/builtins-arm.cc	View		3 chunks	+10 lines, -418 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 2 3	6 chunks	+57 lines, -134 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2 3	2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 2	2 chunks	+8 lines, -19 lines	0 comments	Download
M	src/builtins.h	View	1 2	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/builtins.cc	View	1 2	1 chunk	+14 lines, -16 lines	0 comments	Download
M	src/flag-definitions.h	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3	1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View		3 chunks	+10 lines, -487 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2 3	6 chunks	+58 lines, -133 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	2 chunks	+3 lines, -7 lines	0 comments	Download
	src/ia32/lithium-ia32.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/builtins-mips.cc	View	1 2	3 chunks	+10 lines, -432 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 2 3	6 chunks	+54 lines, -133 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 2 3	2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View		3 chunks	+10 lines, -426 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2 3	6 chunks	+58 lines, -133 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2	2 chunks	+3 lines, -6 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/mjsunit/allocation-site-info.js	View	1 2	3 chunks	+123 lines, -132 lines	0 comments	Download
	test/mjsunit/array-constructor-feedback.js	View	1 2	3 chunks	+1 line, -8 lines	0 comments	Download
M	test/mjsunit/array-feedback.js	View	1 2	3 chunks	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi guys, here is the long-awaited removal of obsolete assembly array code!

7 years, 6 months ago (2013-06-25 15:28:19 UTC) #1

danno

lgtm with nits https://codereview.chromium.org/16453002/diff/14002/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/16453002/diff/14002/src/hydrogen.cc#newcode8883 src/hydrogen.cc:8883: isolate()->global_context()->array_function(), nit: fit on one line, ...

7 years, 6 months ago (2013-06-25 15:56:59 UTC) #2

Michael Starzinger

LGTM with nits. https://codereview.chromium.org/16453002/diff/14002/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): https://codereview.chromium.org/16453002/diff/14002/src/ia32/code-stubs-ia32.cc#newcode7898 src/ia32/code-stubs-ia32.cc:7898: __ mov(edx, FieldOperand(ebx, PropertyCell::kValueOffset)); nit: Better ...

7 years, 6 months ago (2013-06-25 16:05:22 UTC) #3

mvstanton

Committed patchset #4 manually as r15328 (presubmit successful).

7 years, 6 months ago (2013-06-25 16:31:23 UTC) #4

mvstanton

7 years, 5 months ago (2013-06-27 08:51:02 UTC) #5

Message was sent while issue was closed.

done, thx!

https://codereview.chromium.org/16453002/diff/14002/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/16453002/diff/14002/src/hydrogen.cc#newcode8883
src/hydrogen.cc:8883: isolate()->global_context()->array_function(),
On 2013/06/25 15:56:59, danno wrote:
> nit: fit on one line, it makes one line fewer in the resulting code.

Done.

https://codereview.chromium.org/16453002/diff/14002/src/hydrogen.cc#newcode8884
src/hydrogen.cc:8884: isolate());
On 2013/06/25 15:56:59, danno wrote:
> nit: fit on one line, it makes one line fewer in the resulting code.

Done.

https://codereview.chromium.org/16453002/diff/14002/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/16453002/diff/14002/src/ia32/code-stubs-ia32....
src/ia32/code-stubs-ia32.cc:7898: __ mov(edx, FieldOperand(ebx,
PropertyCell::kValueOffset));
On 2013/06/25 16:05:22, Michael Starzinger wrote:
> nit: Better stick with Cell::kValueOffset here, it's not a property call.
Might
> apply to other architectures as well.

Done.

https://codereview.chromium.org/16453002/diff/14002/src/ia32/lithium-codegen-...
File src/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/16453002/diff/14002/src/ia32/lithium-codegen-...
src/ia32/lithium-codegen-ia32.cc:4173: Handle<Object>
undefined_value(isolate()->heap()->undefined_value(),
On 2013/06/25 16:05:22, Michael Starzinger wrote:
> nit: Better use isolate()->factory()->undefined_value() here. Might apply to
> other architectures as well.

Done.

Expand Messages | Collapse Messages