Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 16453002: Removed flag optimize-constructed-arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comment fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3854 matching lines...) Expand 10 before | Expand all | Expand 10 after
3865 CALL_AS_FUNCTION, 3865 CALL_AS_FUNCTION,
3866 RDI_UNINITIALIZED); 3866 RDI_UNINITIALIZED);
3867 } 3867 }
3868 3868
3869 3869
3870 void LCodeGen::DoCallNew(LCallNew* instr) { 3870 void LCodeGen::DoCallNew(LCallNew* instr) {
3871 ASSERT(ToRegister(instr->constructor()).is(rdi)); 3871 ASSERT(ToRegister(instr->constructor()).is(rdi));
3872 ASSERT(ToRegister(instr->result()).is(rax)); 3872 ASSERT(ToRegister(instr->result()).is(rax));
3873 3873
3874 __ Set(rax, instr->arity()); 3874 __ Set(rax, instr->arity());
3875 if (FLAG_optimize_constructed_arrays) { 3875 // No cell in ebx for construct type feedback in optimized code
3876 // No cell in ebx for construct type feedback in optimized code 3876 Handle<Object> undefined_value(isolate()->factory()->undefined_value());
3877 Handle<Object> undefined_value(isolate()->factory()->undefined_value()); 3877 __ Move(rbx, undefined_value);
3878 __ Move(rbx, undefined_value);
3879 }
3880 CallConstructStub stub(NO_CALL_FUNCTION_FLAGS); 3878 CallConstructStub stub(NO_CALL_FUNCTION_FLAGS);
3881 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 3879 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
3882 } 3880 }
3883 3881
3884 3882
3885 void LCodeGen::DoCallNewArray(LCallNewArray* instr) { 3883 void LCodeGen::DoCallNewArray(LCallNewArray* instr) {
3886 ASSERT(ToRegister(instr->constructor()).is(rdi)); 3884 ASSERT(ToRegister(instr->constructor()).is(rdi));
3887 ASSERT(ToRegister(instr->result()).is(rax)); 3885 ASSERT(ToRegister(instr->result()).is(rax));
3888 ASSERT(FLAG_optimize_constructed_arrays);
3889 3886
3890 __ Set(rax, instr->arity()); 3887 __ Set(rax, instr->arity());
3891 __ Move(rbx, instr->hydrogen()->property_cell()); 3888 __ Move(rbx, instr->hydrogen()->property_cell());
3892 ElementsKind kind = instr->hydrogen()->elements_kind(); 3889 ElementsKind kind = instr->hydrogen()->elements_kind();
3893 bool disable_allocation_sites = 3890 bool disable_allocation_sites =
3894 (AllocationSiteInfo::GetMode(kind) == TRACK_ALLOCATION_SITE); 3891 (AllocationSiteInfo::GetMode(kind) == TRACK_ALLOCATION_SITE);
3895 3892
3896 if (instr->arity() == 0) { 3893 if (instr->arity() == 0) {
3897 ArrayNoArgumentConstructorStub stub(kind, disable_allocation_sites); 3894 ArrayNoArgumentConstructorStub stub(kind, disable_allocation_sites);
3898 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 3895 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
(...skipping 1762 matching lines...) Expand 10 before | Expand all | Expand 10 after
5661 FixedArray::kHeaderSize - kPointerSize)); 5658 FixedArray::kHeaderSize - kPointerSize));
5662 __ bind(&done); 5659 __ bind(&done);
5663 } 5660 }
5664 5661
5665 5662
5666 #undef __ 5663 #undef __
5667 5664
5668 } } // namespace v8::internal 5665 } } // namespace v8::internal
5669 5666
5670 #endif // V8_TARGET_ARCH_X64 5667 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698