Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 16453002: Removed flag optimize-constructed-arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comment fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/bootstrapper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4110 matching lines...) Expand 10 before | Expand all | Expand 10 after
4121 CALL_AS_FUNCTION, 4121 CALL_AS_FUNCTION,
4122 R1_UNINITIALIZED); 4122 R1_UNINITIALIZED);
4123 } 4123 }
4124 4124
4125 4125
4126 void LCodeGen::DoCallNew(LCallNew* instr) { 4126 void LCodeGen::DoCallNew(LCallNew* instr) {
4127 ASSERT(ToRegister(instr->constructor()).is(r1)); 4127 ASSERT(ToRegister(instr->constructor()).is(r1));
4128 ASSERT(ToRegister(instr->result()).is(r0)); 4128 ASSERT(ToRegister(instr->result()).is(r0));
4129 4129
4130 __ mov(r0, Operand(instr->arity())); 4130 __ mov(r0, Operand(instr->arity()));
4131 if (FLAG_optimize_constructed_arrays) { 4131 // No cell in r2 for construct type feedback in optimized code
4132 // No cell in r2 for construct type feedback in optimized code 4132 Handle<Object> undefined_value(isolate()->factory()->undefined_value());
4133 Handle<Object> undefined_value(isolate()->heap()->undefined_value(), 4133 __ mov(r2, Operand(undefined_value));
4134 isolate());
4135 __ mov(r2, Operand(undefined_value));
4136 }
4137 CallConstructStub stub(NO_CALL_FUNCTION_FLAGS); 4134 CallConstructStub stub(NO_CALL_FUNCTION_FLAGS);
4138 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 4135 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
4139 } 4136 }
4140 4137
4141 4138
4142 void LCodeGen::DoCallNewArray(LCallNewArray* instr) { 4139 void LCodeGen::DoCallNewArray(LCallNewArray* instr) {
4143 ASSERT(ToRegister(instr->constructor()).is(r1)); 4140 ASSERT(ToRegister(instr->constructor()).is(r1));
4144 ASSERT(ToRegister(instr->result()).is(r0)); 4141 ASSERT(ToRegister(instr->result()).is(r0));
4145 ASSERT(FLAG_optimize_constructed_arrays);
4146 4142
4147 __ mov(r0, Operand(instr->arity())); 4143 __ mov(r0, Operand(instr->arity()));
4148 __ mov(r2, Operand(instr->hydrogen()->property_cell())); 4144 __ mov(r2, Operand(instr->hydrogen()->property_cell()));
4149 ElementsKind kind = instr->hydrogen()->elements_kind(); 4145 ElementsKind kind = instr->hydrogen()->elements_kind();
4150 bool disable_allocation_sites = 4146 bool disable_allocation_sites =
4151 (AllocationSiteInfo::GetMode(kind) == TRACK_ALLOCATION_SITE); 4147 (AllocationSiteInfo::GetMode(kind) == TRACK_ALLOCATION_SITE);
4152 4148
4153 if (instr->arity() == 0) { 4149 if (instr->arity() == 0) {
4154 ArrayNoArgumentConstructorStub stub(kind, disable_allocation_sites); 4150 ArrayNoArgumentConstructorStub stub(kind, disable_allocation_sites);
4155 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 4151 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
(...skipping 1768 matching lines...) Expand 10 before | Expand all | Expand 10 after
5924 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5920 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5925 __ ldr(result, FieldMemOperand(scratch, 5921 __ ldr(result, FieldMemOperand(scratch,
5926 FixedArray::kHeaderSize - kPointerSize)); 5922 FixedArray::kHeaderSize - kPointerSize));
5927 __ bind(&done); 5923 __ bind(&done);
5928 } 5924 }
5929 5925
5930 5926
5931 #undef __ 5927 #undef __
5932 5928
5933 } } // namespace v8::internal 5929 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698