content/browser/notifications/notification_database_data_conversions.cc - Issue 1644573002: Notification actions may have an icon url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_database_data_conversions.cc

Issue 1644573002: Notification actions may have an icon url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_database_data.proto ('k') | content/browser/notifications/notification_database_data_unittest.cc » ('j') | content/child/notifications/notification_data_conversions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_database_data_conversions.cc

diff --git a/content/browser/notifications/notification_database_data_conversions.cc b/content/browser/notifications/notification_database_data_conversions.cc

index cf19704f9dc20e209022b60d5aa26a633dca5bd5..fa95778c87c40513f8dc97a85d38c1559cfdaf1e 100644

--- a/content/browser/notifications/notification_database_data_conversions.cc

+++ b/content/browser/notifications/notification_database_data_conversions.cc

@@ -68,6 +68,7 @@ bool DeserializeNotificationDatabaseData(const std::string& input,

PlatformNotificationAction action;

action.action = payload_action.action();

action.title = base::UTF8ToUTF16(payload_action.title());

+ action.icon = GURL(payload_action.icon());

notification_data->actions.push_back(action);

}

@@ -121,6 +122,7 @@ bool SerializeNotificationDatabaseData(const NotificationDatabaseData& input,

payload->add_actions();

payload_action->set_action(action.action);

payload_action->set_title(base::UTF16ToUTF8(action.title));

+ payload_action->set_icon(action.icon.spec());

}

NotificationDatabaseDataProto message;