content/browser/notifications/notification_database_data.proto - Issue 1644573002: Notification actions may have an icon url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_database_data.proto

Issue 1644573002: Notification actions may have an icon url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/notifications/notification_database_data.proto

diff --git a/content/browser/notifications/notification_database_data.proto b/content/browser/notifications/notification_database_data.proto

index 3047d2b4356e28c5b79410ad156eb755fd97687b..dfd38577cb3ab3c4bd735d853d3626bf3686c129 100644

--- a/content/browser/notifications/notification_database_data.proto

+++ b/content/browser/notifications/notification_database_data.proto

@@ -20,10 +20,11 @@ message NotificationDatabaseDataProto {

// A notification action, corresponds to content::PlatformNotificationAction.

- // Next tag: 3

+ // Next tag: 4

message NotificationAction {

optional string action = 1;

optional string title = 2;

+ optional string icon = 3;

}

// Actual data payload of the notification. This message is the protocol