Notification actions may have an icon url.

content/child/notifications/notification_data_conversions.cc

Index: content/child/notifications/notification_data_conversions.cc
diff --git a/content/child/notifications/notification_data_conversions.cc b/content/child/notifications/notification_data_conversions.cc
index 783d5a2380a5e5baa045b8dff447d105abae6117..c37a1c53b5c95191f2aa1e2d9f5ff36bc50e41b2 100644
--- a/content/child/notifications/notification_data_conversions.cc
+++ b/content/child/notifications/notification_data_conversions.cc
@@ -50,6 +50,8 @@ PlatformNotificationData ToPlatformNotificationData(
     platform_data.actions[i].action =
         base::UTF16ToUTF8(base::StringPiece16(web_data.actions[i].action));
     platform_data.actions[i].title = web_data.actions[i].title;
+    platform_data.actions[i].icon =
+        blink::WebStringToGURL(web_data.actions[i].icon.string());

[Peter Beverloo, 2016/01/27 17:14:23]

PTAL at content/child/notifications/notification_data_conversions_unittest.cc

[jochen (gone - plz use gerrit), 2016/01/28 12:12:24]

should there be a max length of the URL?

[Michael van Ouwerkerk, 2016/02/01 14:39:22]

Are you asking because this might be too large for Chrome to handle? Shouldn't
that kind of check take place in the JS bindings already, or as soon after that
as possible? In this case, this enters the system as a string from JS, is passed
into ExecutionContext.completeUrl, and then into a KURL constructor.

[Michael van Ouwerkerk, 2016/02/01 14:39:23]

Done.

   }
 
   return platform_data;
@@ -87,6 +89,7 @@ WebNotificationData ToWebNotificationData(
     web_data.actions[i].action =
         blink::WebString::fromUTF8(platform_data.actions[i].action);
     web_data.actions[i].title = platform_data.actions[i].title;
+    web_data.actions[i].icon = blink::WebURL(platform_data.actions[i].icon);
   }
 
   return web_data;