Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1644353002: Enable blink_perf.canvas on Android Perf bots (Closed)

Created:
4 years, 10 months ago by dshwang
Modified:
4 years ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable blink_perf.canvas on Android Perf bots As the blocking issue was fixed, re-enable it. BUG=496707, 592017 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/7d700edf761d46092b24d53ee228ce0df6e7b054 Cr-Commit-Position: refs/heads/master@{#379686}

Patch Set 1 #

Patch Set 2 : rebase to ToT #

Patch Set 3 : show FATAL log #

Patch Set 4 : move video file to child folder #

Patch Set 5 : change video code to be same to webgl conformance tests #

Patch Set 6 : print out why SecurityError is fired #

Patch Set 7 : add log to canvas 2d also #

Patch Set 8 : print document url #

Patch Set 9 : rebase to ToT #

Patch Set 10 : add --reduce-security-for-testing #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -64 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -0 lines 1 comment Download
M third_party/WebKit/PerformanceTests/Canvas/draw-dynamic-webgl-to-hw-accelerated-canvas-2d.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Canvas/draw-static-webgl-to-hw-accelerated-canvas-2d.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Canvas/draw-video-to-hw-accelerated-canvas-2d.html View 1 2 3 4 2 chunks +6 lines, -17 lines 0 comments Download
A + third_party/WebKit/PerformanceTests/Canvas/resources/bear-1280x720.mp4 View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/PerformanceTests/Canvas/resources/canvas_runner.js View 1 2 3 4 3 chunks +36 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Canvas/upload-canvas-2d-to-texture.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Canvas/upload-video-to-sub-texture.html View 1 2 3 4 2 chunks +7 lines, -19 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Canvas/upload-video-to-texture.html View 1 2 3 4 2 chunks +7 lines, -18 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Canvas/upload-webgl-to-texture.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/PerformanceTests/resources/bear-1280x720.mp4 View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/PerformanceTests/resources/runner.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -3 lines 1 comment Download

Messages

Total messages: 146 (58 generated)
dshwang
kbr, could you review? I'll watch those bots and make sure the newly enabled tests ...
4 years, 10 months ago (2016-01-29 14:37:15 UTC) #4
Ken Russell (switch to Gerrit)
Thanks for re-visiting this. lgtm
4 years, 10 months ago (2016-01-30 02:14:05 UTC) #5
qyearsley
lgtm
4 years, 10 months ago (2016-01-31 20:57:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/1
4 years, 10 months ago (2016-01-31 20:57:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/140885)
4 years, 10 months ago (2016-01-31 21:07:24 UTC) #10
dshwang
On 2016/01/31 21:07:24, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-01 10:53:19 UTC) #11
qyearsley
On 2016/02/01 10:53:19, dshwang wrote: > On 2016/01/31 21:07:24, commit-bot: I haz the power wrote: ...
4 years, 10 months ago (2016-02-01 18:17:29 UTC) #12
dshwang
Thank you for providing log. I guess nexus 5 bot is also flaky, because my ...
4 years, 10 months ago (2016-02-01 19:27:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/1
4 years, 10 months ago (2016-02-01 19:27:52 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/1915)
4 years, 10 months ago (2016-02-01 19:36:13 UTC) #17
dtu
lgtm
4 years, 10 months ago (2016-02-01 19:59:25 UTC) #19
aiolos (Not reviewing)
lgtm if it passes the android bisect. Also, you may need to rebase since I ...
4 years, 10 months ago (2016-02-01 20:01:28 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/1
4 years, 10 months ago (2016-02-03 18:41:22 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/17013) android_compile_dbg on ...
4 years, 10 months ago (2016-02-03 18:47:17 UTC) #25
qyearsley
dongseong.hwang: This CL is waiting on a rebase now before it can be committed.
4 years, 10 months ago (2016-02-03 18:56:03 UTC) #26
dshwang
On 2016/02/03 18:56:03, qyearsley wrote: > dongseong.hwang: This CL is waiting on a rebase now ...
4 years, 10 months ago (2016-02-03 19:43:13 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/20001
4 years, 10 months ago (2016-02-03 19:44:26 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 10 months ago (2016-02-03 21:48:09 UTC) #32
dshwang
qyearsley, could you copy&paste logs again? Thank you. https://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3289/steps/blink_perf.canvas
4 years, 10 months ago (2016-02-04 21:10:35 UTC) #33
aiolos (Not reviewing)
On 2016/02/04 21:10:35, dshwang wrote: > qyearsley, could you copy&paste logs again? Thank you. > ...
4 years, 10 months ago (2016-02-04 21:27:48 UTC) #34
dshwang
Thank you for showing log. I'm strongly suspecting the nexus 5 perf bot don't support ...
4 years, 10 months ago (2016-02-05 12:50:19 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/40001
4 years, 10 months ago (2016-02-05 12:51:19 UTC) #37
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3298)
4 years, 10 months ago (2016-02-05 16:22:38 UTC) #39
qyearsley
On 2016/02/05 at 16:22:38, commit-bot wrote: > Dry run: Try jobs failed on following builders: ...
4 years, 10 months ago (2016-02-05 17:43:53 UTC) #40
dshwang
On 2016/02/05 17:43:53, qyearsley wrote: > On 2016/02/05 at 16:22:38, commit-bot wrote: > > Dry ...
4 years, 10 months ago (2016-02-05 19:39:08 UTC) #41
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/60001
4 years, 10 months ago (2016-02-05 20:01:08 UTC) #43
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3304)
4 years, 10 months ago (2016-02-06 00:14:32 UTC) #45
Ken Russell (switch to Gerrit)
On 2016/02/05 19:39:08, dshwang wrote: > On 2016/02/05 17:43:53, qyearsley wrote: > > On 2016/02/05 ...
4 years, 10 months ago (2016-02-09 02:05:24 UTC) #46
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/80001
4 years, 10 months ago (2016-02-22 15:52:33 UTC) #48
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3408)
4 years, 10 months ago (2016-02-22 17:47:24 UTC) #50
dshwang
sorry for delaying handling it. Let me restart. I changed the video code according to ...
4 years, 10 months ago (2016-02-22 18:12:03 UTC) #51
qyearsley
On 2016/02/22 at 18:12:03, dongseong.hwang wrote: > sorry for delaying handling it. Let me restart. ...
4 years, 10 months ago (2016-02-23 00:23:30 UTC) #52
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/100001
4 years, 10 months ago (2016-02-23 12:00:36 UTC) #55
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/185279) win_chromium_rel_ng on ...
4 years, 10 months ago (2016-02-23 12:51:19 UTC) #57
dshwang
qyearsley, I added more printf to figure out why. Could you copy&paste one more time? ...
4 years, 10 months ago (2016-02-23 15:20:20 UTC) #58
qyearsley
On 2016/02/23 15:20:20, dshwang wrote: > qyearsley, I added more printf to figure out why. ...
4 years, 10 months ago (2016-02-23 17:53:46 UTC) #59
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/120001
4 years, 10 months ago (2016-02-23 20:16:31 UTC) #61
dshwang
On 2016/02/23 17:53:46, qyearsley wrote: > On 2016/02/23 15:20:20, dshwang wrote: > > qyearsley, I ...
4 years, 10 months ago (2016-02-23 20:18:31 UTC) #62
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/120001
4 years, 10 months ago (2016-02-23 20:22:24 UTC) #66
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/26172) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-23 20:28:04 UTC) #68
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/120001
4 years, 10 months ago (2016-02-24 08:31:12 UTC) #70
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/149495) linux_chromium_rel_ng on ...
4 years, 10 months ago (2016-02-24 08:37:50 UTC) #72
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/160001
4 years, 10 months ago (2016-02-24 09:37:14 UTC) #76
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3423)
4 years, 10 months ago (2016-02-24 09:55:30 UTC) #78
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/160001
4 years, 10 months ago (2016-02-24 13:20:32 UTC) #80
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/178751)
4 years, 10 months ago (2016-02-24 14:38:03 UTC) #82
dshwang
qyearsley@, I added the log code to canvas 2d code also. Could you copy&paste the ...
4 years, 10 months ago (2016-02-24 16:21:56 UTC) #83
qyearsley
On 2016/02/24 at 16:21:56, dongseong.hwang wrote: > qyearsley@, I added the log code to canvas ...
4 years, 10 months ago (2016-02-24 18:29:05 UTC) #84
Ken Russell (switch to Gerrit)
On 2016/02/24 18:29:05, qyearsley wrote: > On 2016/02/24 at 16:21:56, dongseong.hwang wrote: > > qyearsley@, ...
4 years, 10 months ago (2016-02-24 18:58:48 UTC) #85
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/180001
4 years, 10 months ago (2016-02-24 20:27:17 UTC) #87
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/26599) android_chromium_gn_compile_dbg on ...
4 years, 10 months ago (2016-02-24 20:31:44 UTC) #91
dshwang
On 2016/02/24 18:58:48, Ken Russell wrote: > > Ah, I see -- alright, now we ...
4 years, 10 months ago (2016-02-24 20:41:39 UTC) #93
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/220001
4 years, 10 months ago (2016-02-25 18:27:06 UTC) #96
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/185865)
4 years, 10 months ago (2016-02-25 19:22:53 UTC) #98
dshwang
On 2016/02/24 20:41:39, dshwang wrote: > document url should be > http://127.0.0.1:43178/Canvas/draw-video-to-hw-accelerated-canvas-2d.html > Let me ...
4 years, 10 months ago (2016-02-25 19:53:52 UTC) #99
qyearsley
On 2016/02/25 19:53:52, dshwang wrote: > On 2016/02/24 20:41:39, dshwang wrote: > > document url ...
4 years, 10 months ago (2016-02-25 22:48:26 UTC) #100
qyearsley
> In the latest run of blink_perf.canvas on android_nexus5_perf_bisect, there are > no lines that ...
4 years, 10 months ago (2016-02-25 23:01:32 UTC) #101
dshwang
On 2016/02/25 23:01:32, qyearsley wrote: > > In the latest run of blink_perf.canvas on android_nexus5_perf_bisect, ...
4 years, 10 months ago (2016-02-26 06:48:53 UTC) #102
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/220001
4 years, 10 months ago (2016-02-26 06:49:36 UTC) #104
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/186454)
4 years, 10 months ago (2016-02-26 06:55:34 UTC) #106
dshwang
On 2016/02/25 23:01:32, qyearsley wrote: > > In the latest run of blink_perf.canvas on android_nexus5_perf_bisect, ...
4 years, 10 months ago (2016-02-26 14:23:54 UTC) #107
qyearsley
On 2016/02/26 at 14:23:54, dongseong.hwang wrote: > On 2016/02/25 23:01:32, qyearsley wrote: > > > ...
4 years, 10 months ago (2016-02-26 16:49:22 UTC) #108
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/240001
4 years, 10 months ago (2016-02-26 18:25:03 UTC) #110
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/136539)
4 years, 10 months ago (2016-02-26 19:22:11 UTC) #112
dshwang
On 2016/02/26 16:49:22, qyearsley wrote: > Last try job run had a patch error, which ...
4 years, 9 months ago (2016-02-27 11:39:46 UTC) #113
dshwang
On 2016/02/27 11:39:46, dshwang wrote: > On 2016/02/26 16:49:22, qyearsley wrote: > > Last try ...
4 years, 9 months ago (2016-03-02 11:00:53 UTC) #114
qyearsley
On 2016/03/02 11:00:53, dshwang wrote: > On 2016/02/27 11:39:46, dshwang wrote: > > On 2016/02/26 ...
4 years, 9 months ago (2016-03-02 17:29:35 UTC) #115
qyearsley
On 2016/03/02 11:00:53, dshwang wrote: > On 2016/02/27 11:39:46, dshwang wrote: > > On 2016/02/26 ...
4 years, 9 months ago (2016-03-02 17:29:36 UTC) #116
dshwang
On 2016/03/02 17:29:36, qyearsley wrote: > On 2016/03/02 11:00:53, dshwang wrote: > > On 2016/02/27 ...
4 years, 9 months ago (2016-03-02 17:56:23 UTC) #117
qyearsley
On 2016/03/02 17:56:23, dshwang wrote: > On 2016/03/02 17:29:36, qyearsley wrote: > > On 2016/03/02 ...
4 years, 9 months ago (2016-03-02 18:38:06 UTC) #118
dshwang
On 2016/03/02 18:38:06, qyearsley wrote: > > > From latest run on android_nexus5_perf_bisect: > > ...
4 years, 9 months ago (2016-03-02 18:50:55 UTC) #119
Ken Russell (switch to Gerrit)
On 2016/03/02 18:50:55, dshwang wrote: > On 2016/03/02 18:38:06, qyearsley wrote: > > > > ...
4 years, 9 months ago (2016-03-02 19:44:30 UTC) #120
dshwang
On 2016/03/02 19:44:30, Ken Russell wrote: > On 2016/03/02 18:50:55, dshwang wrote: > > On ...
4 years, 9 months ago (2016-03-02 21:22:37 UTC) #121
qyearsley
On 2016/03/02 21:22:37, dshwang wrote: > On 2016/03/02 19:44:30, Ken Russell wrote: > > On ...
4 years, 9 months ago (2016-03-02 22:00:44 UTC) #122
Ken Russell (switch to Gerrit)
On 2016/03/02 22:00:44, qyearsley wrote: > On 2016/03/02 21:22:37, dshwang wrote: > > On 2016/03/02 ...
4 years, 9 months ago (2016-03-02 22:42:14 UTC) #123
dshwang
On 2016/03/02 22:42:14, Ken Russell wrote: > On 2016/03/02 22:00:44, qyearsley wrote: > > On ...
4 years, 9 months ago (2016-03-03 08:35:27 UTC) #124
Ken Russell (switch to Gerrit)
On 2016/03/03 08:35:27, dshwang wrote: > On 2016/03/02 22:42:14, Ken Russell wrote: > > On ...
4 years, 9 months ago (2016-03-03 16:51:53 UTC) #125
dshwang
> > kbr, there is --reduce-security-for-testing commend line. > > I think we can reuse ...
4 years, 9 months ago (2016-03-04 16:30:51 UTC) #127
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/280001
4 years, 9 months ago (2016-03-04 16:31:26 UTC) #130
Ken Russell (switch to Gerrit)
Very nice Dongseong. LGTM again.
4 years, 9 months ago (2016-03-04 18:21:43 UTC) #131
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 19:09:51 UTC) #133
aiolos (Not reviewing)
still lgtm
4 years, 9 months ago (2016-03-04 19:24:53 UTC) #134
dshwang
qinmin, DaleCurtis, could you review webmediaplayer_android.cc ?
4 years, 9 months ago (2016-03-05 10:11:44 UTC) #137
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-07 18:36:58 UTC) #138
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644353002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644353002/280001
4 years, 9 months ago (2016-03-07 19:55:09 UTC) #141
dshwang
On 2016/03/07 18:36:58, DaleCurtis wrote: > lgtm Thank you, Ken, qyearsley and all for persevering ...
4 years, 9 months ago (2016-03-07 20:50:20 UTC) #142
commit-bot: I haz the power
Committed patchset #10 (id:280001)
4 years, 9 months ago (2016-03-08 00:04:51 UTC) #144
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 00:07:05 UTC) #146
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/7d700edf761d46092b24d53ee228ce0df6e7b054
Cr-Commit-Position: refs/heads/master@{#379686}

Powered by Google App Engine
This is Rietveld 408576698