Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 1644353002: Enable blink_perf.canvas on Android Perf bots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add --reduce-security-for-testing Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/blink_perf.py
diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py
index a7123491624a43156123789d98e0ea27f4ff963b..a3d6fcedc330c4c72c4b77ac2ea5f4ade5d55f47 100644
--- a/tools/perf/benchmarks/blink_perf.py
+++ b/tools/perf/benchmarks/blink_perf.py
@@ -88,7 +88,9 @@ class _BlinkPerfMeasurement(page_test.PageTest):
'--js-flags=--expose_gc',
'--enable-experimental-web-platform-features',
'--disable-gesture-requirement-for-media-playback',
- '--enable-experimental-canvas-features'
+ '--enable-experimental-canvas-features',
+ # TODO(qinmin): After fixing crbug.com/592017, remove this command line.
+ '--reduce-security-for-testing'
dshwang 2016/03/04 16:30:51 add the command line
])
if 'content-shell' in options.browser_type:
options.AppendExtraBrowserArgs('--expose-internals-for-testing')
@@ -99,6 +101,9 @@ class _BlinkPerfMeasurement(page_test.PageTest):
log = tab.EvaluateJavaScript('document.getElementById("log").innerHTML')
for line in log.splitlines():
+ if line.startswith("FATAL: "):
+ print line
+ continue
if not line.startswith('values '):
continue
parts = line.split()
@@ -166,8 +171,7 @@ class BlinkPerfCSS(perf_benchmark.PerfBenchmark):
return CreateStorySetFromPath(path, SKIPPED_FILE)
-@benchmark.Disabled('android', # http://crbug.com/496707
- 'reference') # http://crbug.com/576779
+@benchmark.Disabled('reference') # http://crbug.com/576779
class BlinkPerfCanvas(perf_benchmark.PerfBenchmark):
tag = 'canvas'
test = _BlinkPerfMeasurement

Powered by Google App Engine
This is Rietveld 408576698