Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1643673002: Diagnose RenderFrameImpl::didCommitProvisionalLoad crash. (Closed)

Created:
4 years, 11 months ago by Charlie Reis
Modified:
4 years, 11 months ago
Reviewers:
Robert Sesek, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Diagnose RenderFrameImpl::didCommitProvisionalLoad crash. The previous theories haven't held up, so these crash keys will help reveal how the proxy is being created. They cover all the ways of reaching the RenderFrameProxy constructor (i.e., RVI::Initialize, RFI::OnSwapOut, and RTI::OnCreateNewFrameProxy). BUG=575245 TEST=New crash keys present in crash reports. Committed: https://crrev.com/9f7248b6d1e19df68f77fd242fcd884ae534a8fa Cr-Commit-Position: refs/heads/master@{#371857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/common/crash_keys.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Charlie Reis
Nasko, can you review? This should cover all the ways that RenderFrameProxies can be created, ...
4 years, 11 months ago (2016-01-27 19:17:05 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643673002/1
4 years, 11 months ago (2016-01-27 19:19:58 UTC) #5
nasko
LGTM
4 years, 11 months ago (2016-01-27 19:24:19 UTC) #6
Robert Sesek
lgtm
4 years, 11 months ago (2016-01-27 19:25:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643673002/1
4 years, 11 months ago (2016-01-27 19:29:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 20:27:47 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 20:29:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f7248b6d1e19df68f77fd242fcd884ae534a8fa
Cr-Commit-Position: refs/heads/master@{#371857}

Powered by Google App Engine
This is Rietveld 408576698