Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 1643673002: Diagnose RenderFrameImpl::didCommitProvisionalLoad crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index c22b0a73fff889df000e06f40e139de6427dbaf0..e94df24290b687a85302e7e863f53b3f708ed6c5 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -12,6 +12,7 @@
#include "base/allocator/allocator_extension.h"
#include "base/command_line.h"
+#include "base/debug/crash_logging.h"
#include "base/lazy_instance.h"
#include "base/location.h"
#include "base/logging.h"
@@ -1764,6 +1765,15 @@ void RenderThreadImpl::OnCreateNewFrameProxy(
int opener_routing_id,
int parent_routing_id,
const FrameReplicationState& replicated_state) {
+ // Debug cases of https://crbug.com/575245.
+ base::debug::SetCrashKeyValue("newproxy_proxy_id",
+ base::IntToString(routing_id));
+ base::debug::SetCrashKeyValue("newproxy_view_id",
+ base::IntToString(render_view_routing_id));
+ base::debug::SetCrashKeyValue("newproxy_opener_id",
+ base::IntToString(opener_routing_id));
+ base::debug::SetCrashKeyValue("newproxy_parent_id",
+ base::IntToString(parent_routing_id));
RenderFrameProxy::CreateFrameProxy(routing_id, render_view_routing_id,
opener_routing_id, parent_routing_id,
replicated_state);
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698