Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1643573003: Call RecordWriteIntoCode in RelocInfo::set_target_cell. (Closed)

Created:
4 years, 10 months ago by Hannes Payer (out of office)
Modified:
4 years, 10 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, Hannes Payer (out of office), ulan, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Call RecordWriteIntoCode in RelocInfo::set_target_cell. This currently works since we never call set_target_cell when we have to record slots for evacuation. It would break with black allocation. BUG=chromium:561449 LOG=n Committed: https://crrev.com/1547136c4e897d492e242dec233cc1363d054917 Cr-Commit-Position: refs/heads/master@{#33575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M src/arm/assembler-arm-inl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
payer
4 years, 10 months ago (2016-01-28 07:02:37 UTC) #4
ulan
lgtm
4 years, 10 months ago (2016-01-28 08:48:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643573003/1
4 years, 10 months ago (2016-01-28 09:09:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 09:14:26 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 09:14:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1547136c4e897d492e242dec233cc1363d054917
Cr-Commit-Position: refs/heads/master@{#33575}

Powered by Google App Engine
This is Rietveld 408576698