Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/mips/assembler-mips-inl.h

Issue 1643573003: Call RecordWriteIntoCode in RelocInfo::set_target_cell. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/assembler-ia32-inl.h ('k') | src/mips64/assembler-mips64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright (c) 1994-2006 Sun Microsystems Inc. 2 // Copyright (c) 1994-2006 Sun Microsystems Inc.
3 // All Rights Reserved. 3 // All Rights Reserved.
4 // 4 //
5 // Redistribution and use in source and binary forms, with or without 5 // Redistribution and use in source and binary forms, with or without
6 // modification, are permitted provided that the following conditions are 6 // modification, are permitted provided that the following conditions are
7 // met: 7 // met:
8 // 8 //
9 // - Redistributions of source code must retain the above copyright notice, 9 // - Redistributions of source code must retain the above copyright notice,
10 // this list of conditions and the following disclaimer. 10 // this list of conditions and the following disclaimer.
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 } 277 }
278 278
279 279
280 void RelocInfo::set_target_cell(Cell* cell, 280 void RelocInfo::set_target_cell(Cell* cell,
281 WriteBarrierMode write_barrier_mode, 281 WriteBarrierMode write_barrier_mode,
282 ICacheFlushMode icache_flush_mode) { 282 ICacheFlushMode icache_flush_mode) {
283 DCHECK(rmode_ == RelocInfo::CELL); 283 DCHECK(rmode_ == RelocInfo::CELL);
284 Address address = cell->address() + Cell::kValueOffset; 284 Address address = cell->address() + Cell::kValueOffset;
285 Memory::Address_at(pc_) = address; 285 Memory::Address_at(pc_) = address;
286 if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL) { 286 if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL) {
287 // TODO(1550) We are passing NULL as a slot because cell can never be on 287 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(host(), this,
288 // evacuation candidate. 288 cell);
289 host()->GetHeap()->incremental_marking()->RecordWrite(
290 host(), NULL, cell);
291 } 289 }
292 } 290 }
293 291
294 292
295 static const int kNoCodeAgeSequenceLength = 7 * Assembler::kInstrSize; 293 static const int kNoCodeAgeSequenceLength = 7 * Assembler::kInstrSize;
296 294
297 295
298 Handle<Object> RelocInfo::code_age_stub_handle(Assembler* origin) { 296 Handle<Object> RelocInfo::code_age_stub_handle(Assembler* origin) {
299 UNREACHABLE(); // This should never be reached on Arm. 297 UNREACHABLE(); // This should never be reached on Arm.
300 return Handle<Object>(); 298 return Handle<Object>();
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 CheckBuffer(); 482 CheckBuffer();
485 } 483 }
486 EmitHelper(x, is_compact_branch); 484 EmitHelper(x, is_compact_branch);
487 } 485 }
488 486
489 487
490 } // namespace internal 488 } // namespace internal
491 } // namespace v8 489 } // namespace v8
492 490
493 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_ 491 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_
OLDNEW
« no previous file with comments | « src/ia32/assembler-ia32-inl.h ('k') | src/mips64/assembler-mips64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698