Call OnSwapBuffersComplete at the end of each frame

Call OnSwapBuffersComplete at the end of each frame

While the main compositor code flow works fine without this, this is
needed to keep RenderWidget book-keeping updated on the main thread.
Also re-arranging the did_swap_buffer_ path to share more between
hardware and software mode.

BUG=

[no sievers, 2013-06-05 21:08:05]

lgtm

https://codereview.chromium.org/16430005/diff/1/content/browser/android/in_pr...
File content/browser/android/in_process/synchronous_compositor_output_surface.cc
(right):

https://codereview.chromium.org/16430005/diff/1/content/browser/android/in_pr...
content/browser/android/in_process/synchronous_compositor_output_surface.cc:217:
client_->OnSwapBuffersComplete();
Is it even more straightforward to call this from SwapBuffers() (or maybe post a
task from there)?

[joth, 2013-06-05 21:26:40]

https://codereview.chromium.org/16430005/diff/1/content/browser/android/in_pr...
File content/browser/android/in_process/synchronous_compositor_output_surface.cc
(right):

https://codereview.chromium.org/16430005/diff/1/content/browser/android/in_pr...
content/browser/android/in_process/synchronous_compositor_output_surface.cc:217:
client_->OnSwapBuffersComplete();
On 2013/06/05 21:08:05, Daniel Sievers wrote:
> Is it even more straightforward to call this from SwapBuffers() (or maybe post
a
> task from there)?

SwapBuffers() isn't called in the SW draw case.

[commit-bot: I haz the power, 2013-06-05 21:27:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/16430005/1

[commit-bot: I haz the power, 2013-06-05 21:49:31]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-05 23:23:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/16430005/1

[commit-bot: I haz the power, 2013-06-05 23:39:22]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-06 01:56:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/16430005/16001

[commit-bot: I haz the power, 2013-06-06 18:01:29]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[joth, 2013-06-07 04:02:05]

https://codereview.chromium.org/16430005/diff/47001/content/browser/android/i...
File content/browser/android/in_process/synchronous_compositor_output_surface.cc
(right):

https://codereview.chromium.org/16430005/diff/47001/content/browser/android/i...
content/browser/android/in_process/synchronous_compositor_output_surface.cc:225:
client_->OnSwapBuffersComplete();
BUG: I need to call this back async, as per FakeOutputSurface (else
FrameRateController will cry)

[joth, 2013-06-07 04:02:51]

https://codereview.chromium.org/16430005/diff/47001/content/browser/android/i...
File content/browser/android/in_process/synchronous_compositor_output_surface.cc
(right):

https://codereview.chromium.org/16430005/diff/47001/content/browser/android/i...
content/browser/android/in_process/synchronous_compositor_output_surface.cc:219:
// whole view. Tracking bug to implement this: crbug.com/230463.
BUG: rebase resolve error.

[joth, 2013-06-07 04:28:47]

https://codereview.chromium.org/16430005/diff/47001/content/browser/android/i...
File content/browser/android/in_process/synchronous_compositor_output_surface.cc
(right):

https://codereview.chromium.org/16430005/diff/47001/content/browser/android/i...
content/browser/android/in_process/synchronous_compositor_output_surface.cc:219:
// whole view. Tracking bug to implement this: crbug.com/230463.
On 2013/06/07 04:02:51, joth wrote:
> BUG: rebase resolve error.

fixed in PS5

https://codereview.chromium.org/16430005/diff/47001/content/browser/android/i...
content/browser/android/in_process/synchronous_compositor_output_surface.cc:225:
client_->OnSwapBuffersComplete();
On 2013/06/07 04:02:05, joth wrote:
> BUG: I need to call this back async, as per FakeOutputSurface (else
> FrameRateController will cry)

Actually, not a bug at all. By the point we get here (after the
SetNeedsRedrawRect) we are async w.r.t. the SwapBuffers call.

[aelias_OOO_until_Jul13, 2013-06-10 06:44:47]

FYI, here is my wider refactoring subsuming this patch:
https://codereview.chromium.org/16304003/ .  I haven't tested it with WebView
yet, let me know if it works for you.