Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: content/browser/android/in_process/synchronous_compositor_output_surface.cc

Issue 16430005: Call OnSwapBuffersComplete at the end of each frame (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tidy Begin/End Paint Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/fake_output_surface.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/in_process/synchronous_compositor_output_surface.cc
diff --git a/content/browser/android/in_process/synchronous_compositor_output_surface.cc b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
index b0e2d0e3a4918de3c5470bdce41541f0f433a657..05e04f8e7b0fd2ae090426c5ac122279dd292a74 100644
--- a/content/browser/android/in_process/synchronous_compositor_output_surface.cc
+++ b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
@@ -61,13 +61,15 @@ class SynchronousCompositorOutputSurface::SoftwareDevice
// Intentional no-op: canvas size is controlled by the embedder.
}
virtual SkCanvas* BeginPaint(gfx::Rect damage_rect) OVERRIDE {
- DCHECK(surface_->current_sw_canvas_);
- if (surface_->current_sw_canvas_)
- return surface_->current_sw_canvas_;
- return &null_canvas_;
+ if (!surface_->current_sw_canvas_) {
+ NOTREACHED() << "BeginPaint with no canvas set";
+ return &null_canvas_;
+ }
+ LOG_IF(WARNING, surface_->did_swap_buffer_)
+ << "Mutliple calls to BeginPaint per frame";
+ return surface_->current_sw_canvas_;
}
virtual void EndPaint(cc::SoftwareFrameData* frame_data) OVERRIDE {
- surface_->current_sw_canvas_ = NULL;
}
virtual void CopyToBitmap(gfx::Rect rect, SkBitmap* output) OVERRIDE {
NOTIMPLEMENTED();
@@ -146,7 +148,10 @@ void SynchronousCompositorOutputSurface::SetNeedsBeginFrame(
void SynchronousCompositorOutputSurface::SwapBuffers(
const ui::LatencyInfo& info) {
- context3d()->shallowFlushCHROMIUM();
+ if (!ForcedDrawToSoftwareDevice()) {
+ DCHECK(context3d());
+ context3d()->shallowFlushCHROMIUM();
+ }
did_swap_buffer_ = true;
}
@@ -182,9 +187,8 @@ bool SynchronousCompositorOutputSurface::DemandDrawSw(SkCanvas* canvas) {
InvokeComposite(clip.size());
- bool finished_draw = current_sw_canvas_ == NULL;
current_sw_canvas_ = NULL;
- return finished_draw;
+ return did_swap_buffer_;
}
bool SynchronousCompositorOutputSurface::DemandDrawHw(
@@ -203,8 +207,6 @@ bool SynchronousCompositorOutputSurface::DemandDrawHw(
if (current_context)
current_context->ReleaseCurrent(NULL);
- did_swap_buffer_ = false;
-
gfx::Transform adjusted_transform = transform;
AdjustTransformForClip(&adjusted_transform, clip);
surface_size_ = surface_size;
@@ -216,9 +218,13 @@ bool SynchronousCompositorOutputSurface::DemandDrawHw(
void SynchronousCompositorOutputSurface::InvokeComposite(
gfx::Size damage_size) {
+ did_swap_buffer_ = false;
client_->SetNeedsRedrawRect(gfx::Rect(damage_size));
if (needs_begin_frame_)
client_->BeginFrame(base::TimeTicks::Now());
+
+ if (did_swap_buffer_)
+ client_->OnSwapBuffersComplete();
}
// Not using base::NonThreadSafe as we want to enforce a more exacting threading
« no previous file with comments | « cc/test/fake_output_surface.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698