Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Issue 1642903005: Update geolocation over HTTP error to use PERMISSION_DENIED (Closed)

Created:
4 years, 10 months ago by jww
Modified:
4 years, 10 months ago
CC:
blink-reviews, chromium-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update geolocation over HTTP error to use PERMISSION_DENIED When geolocation is used over HTTP, we had been using POSITION_UNAVAILABLE, but it was pointed out that using geolocation over a file:// URL uses PERMISSION_DENIED instead. To be consistent, this updates the HTTP failure to use PERMISSION_DENIED. BUG=561641 Committed: https://crrev.com/5e9d2e8a2e8d288c87f192a55c1b5fe57388d7c2 Cr-Commit-Position: refs/heads/master@{#372841}

Patch Set 1 #

Patch Set 2 : Add test for correct error code #

Total comments: 6

Patch Set 3 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jww
4 years, 10 months ago (2016-01-29 02:00:35 UTC) #2
Mike West
Test?
4 years, 10 months ago (2016-01-29 06:42:30 UTC) #3
jww
On 2016/01/29 06:42:30, Mike West wrote: > Test? Oh aren't we picky? :-) Will do.
4 years, 10 months ago (2016-01-29 18:40:25 UTC) #4
jww
Test added
4 years, 10 months ago (2016-01-29 19:46:03 UTC) #5
Mike West
LGTM % test nits. https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html File third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html (right): https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html#newcode53 third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html:53: this.step_func(function(error) { This can still ...
4 years, 10 months ago (2016-02-01 06:34:12 UTC) #6
Michael van Ouwerkerk
lgtm with Mike's nits addressed.
4 years, 10 months ago (2016-02-01 15:49:19 UTC) #8
jww
https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html File third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html (right): https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html#newcode53 third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html:53: this.step_func(function(error) { On 2016/02/01 06:34:12, Mike West (OOO until ...
4 years, 10 months ago (2016-02-01 23:28:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642903005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642903005/40001
4 years, 10 months ago (2016-02-01 23:31:00 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-02 00:42:19 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 00:43:40 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5e9d2e8a2e8d288c87f192a55c1b5fe57388d7c2
Cr-Commit-Position: refs/heads/master@{#372841}

Powered by Google App Engine
This is Rietveld 408576698