Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html

Issue 1642903005: Update geolocation over HTTP error to use PERMISSION_DENIED (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Address nits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/geolocation/Geolocation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html b/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
index e210885375af241d5e98c1b907e66c3611f97785..31cd796762209439afc72f6c493de1148bb68f25 100644
--- a/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
+++ b/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
@@ -50,7 +50,9 @@ if (window.location.origin != get_host_info().UNAUTHENTICATED_ORIGIN) {
async_test(function() {
navigator.geolocation.getCurrentPosition(
this.unreached_func('getCurrentPosition should fail, but succeeded.'),
- this.step_func_done());
+ this.step_func_done(function(error) {
+ assert_equals(error.code, error.PERMISSION_DENIED);
+ }));
}, 'getCurrentPosition');
// Note that the deprecation message for watchPosition() will be suppressed
@@ -59,7 +61,9 @@ if (window.location.origin != get_host_info().UNAUTHENTICATED_ORIGIN) {
async_test(function() {
navigator.geolocation.watchPosition(
this.unreached_func('watchPosition should fail, but succeeded.'),
- this.step_func_done());
+ this.step_func_done(function(error) {
+ assert_equals(error.code, error.PERMISSION_DENIED);
+ }));
}, 'watchPosition');
async_test(function() {
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/geolocation/Geolocation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698