Update geolocation over HTTP error to use PERMISSION_DENIED

Update geolocation over HTTP error to use PERMISSION_DENIED

When geolocation is used over HTTP, we had been using
POSITION_UNAVAILABLE, but it was pointed out that using geolocation over
a file:// URL uses PERMISSION_DENIED instead. To be consistent, this
updates the HTTP failure to use PERMISSION_DENIED.

BUG=561641
Committed: https://crrev.com/5e9d2e8a2e8d288c87f192a55c1b5fe57388d7c2
Cr-Commit-Position: refs/heads/master@{#372841}

[jww, 2016-01-29 02:00:34]

jww@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-01-29 06:42:30]

Test?

[jww, 2016-01-29 18:40:25]

On 2016/01/29 06:42:30, Mike West wrote:
> Test?

Oh aren't we picky? :-) Will do.

[jww, 2016-01-29 19:46:03]

Test added

[Mike West, 2016-02-01 06:34:12]

LGTM % test nits.

https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
(right):

https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html:53:
this.step_func(function(error) {
This can still be step_func_done, and that will automagically call `done()` on
the test after executing the function.

https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html:55:
this.done();
Which means you can drop this line.

https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html:65:
this.step_func(function(error) {
Ditto.

[Michael van Ouwerkerk, 2016-02-01 15:49:19]

mvanouwerkerk@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2016-02-01 15:49:19]

lgtm with Mike's nits addressed.

[jww, 2016-02-01 23:28:57]

https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
(right):

https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html:53:
this.step_func(function(error) {
On 2016/02/01 06:34:12, Mike West (OOO until 2nd) wrote:
> This can still be step_func_done, and that will automagically call `done()` on
> the test after executing the function.

Ah, I had no idea that you could pass a function to a step_func_done()! Huzzah!

https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html:55:
this.done();
On 2016/02/01 06:34:12, Mike West (OOO until 2nd) wrote:
> Which means you can drop this line.

Done.

https://codereview.chromium.org/1642903005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html:65:
this.step_func(function(error) {
On 2016/02/01 06:34:12, Mike West (OOO until 2nd) wrote:
> Ditto.

Done.

[jww, 2016-02-01 23:29:00]

The CQ bit was checked by jww@chromium.org

[jww, 2016-02-01 23:29:00]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/1642903005/#ps40001
(title: "Address nits")

[commit-bot: I haz the power, 2016-02-01 23:31:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1642903005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1642903005/40001

[commit-bot: I haz the power, 2016-02-02 00:42:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-02 00:43:39]

Description was changed from

==========
Update geolocation over HTTP error to use PERMISSION_DENIED

When geolocation is used over HTTP, we had been using
POSITION_UNAVAILABLE, but it was pointed out that using geolocation over
a file:// URL uses PERMISSION_DENIED instead. To be consistent, this
updates the HTTP failure to use PERMISSION_DENIED.

BUG=561641
==========

to

==========
Update geolocation over HTTP error to use PERMISSION_DENIED

When geolocation is used over HTTP, we had been using
POSITION_UNAVAILABLE, but it was pointed out that using geolocation over
a file:// URL uses PERMISSION_DENIED instead. To be consistent, this
updates the HTTP failure to use PERMISSION_DENIED.

BUG=561641

Committed: https://crrev.com/5e9d2e8a2e8d288c87f192a55c1b5fe57388d7c2
Cr-Commit-Position: refs/heads/master@{#372841}
==========

[commit-bot: I haz the power, 2016-02-02 00:43:40]

Patchset 3 (id:??) landed as
https://crrev.com/5e9d2e8a2e8d288c87f192a55c1b5fe57388d7c2
Cr-Commit-Position: refs/heads/master@{#372841}