Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1642873002: Use plain pointer comparison in MockWebRtcVideoTrack::RemoveRenderer. (Closed)

Created:
4 years, 10 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 10 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use plain pointer comparison in MockWebRtcVideoTrack::RemoveRenderer. DCHECK_EQ gets confused with pending webrtc changes which make VideoRendererInterface inherit VideoSinkInterface. Committed: https://crrev.com/3029b77c0c2e74eb5e5d4d2ebe63459eaf64adeb Cr-Commit-Position: refs/heads/master@{#372070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-chromium (ooo August 14)
4 years, 10 months ago (2016-01-28 09:27:35 UTC) #2
perkj_chrome
lgtm
4 years, 10 months ago (2016-01-28 09:46:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642873002/1
4 years, 10 months ago (2016-01-28 09:46:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 11:25:54 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 11:26:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3029b77c0c2e74eb5e5d4d2ebe63459eaf64adeb
Cr-Commit-Position: refs/heads/master@{#372070}

Powered by Google App Engine
This is Rietveld 408576698