content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc - Issue 1642873002: Use plain pointer comparison in MockWebRtcVideoTrack::RemoveRenderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc

Issue 1642873002: Use plain pointer comparison in MockWebRtcVideoTrack::RemoveRenderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc

diff --git a/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc b/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc

index d4e61168d6d17aa7552ad6b664f4a702e5a6ac95..2032c3fb96cb507e399578737c9a99dbe5bce1af 100644

--- a/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc

+++ b/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc

@@ -310,7 +310,7 @@ void MockWebRtcVideoTrack::AddRenderer(VideoRendererInterface* renderer) {

}

void MockWebRtcVideoTrack::RemoveRenderer(VideoRendererInterface* renderer) {

- DCHECK_EQ(renderer_, renderer);

+ DCHECK(renderer_ == renderer);

renderer_ = NULL;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »