Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc

Issue 1642873002: Use plain pointer comparison in MockWebRtcVideoTrack::RemoveRenderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/webrtc/mock_peer_connection_dependency_factory. h" 5 #include "content/renderer/media/webrtc/mock_peer_connection_dependency_factory. h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 } 303 }
304 304
305 MockWebRtcVideoTrack::~MockWebRtcVideoTrack() {} 305 MockWebRtcVideoTrack::~MockWebRtcVideoTrack() {}
306 306
307 void MockWebRtcVideoTrack::AddRenderer(VideoRendererInterface* renderer) { 307 void MockWebRtcVideoTrack::AddRenderer(VideoRendererInterface* renderer) {
308 DCHECK(!renderer_); 308 DCHECK(!renderer_);
309 renderer_ = renderer; 309 renderer_ = renderer;
310 } 310 }
311 311
312 void MockWebRtcVideoTrack::RemoveRenderer(VideoRendererInterface* renderer) { 312 void MockWebRtcVideoTrack::RemoveRenderer(VideoRendererInterface* renderer) {
313 DCHECK_EQ(renderer_, renderer); 313 DCHECK(renderer_ == renderer);
314 renderer_ = NULL; 314 renderer_ = NULL;
315 } 315 }
316 316
317 std::string MockWebRtcVideoTrack::kind() const { 317 std::string MockWebRtcVideoTrack::kind() const {
318 NOTIMPLEMENTED(); 318 NOTIMPLEMENTED();
319 return std::string(); 319 return std::string();
320 } 320 }
321 321
322 std::string MockWebRtcVideoTrack::id() const { return id_; } 322 std::string MockWebRtcVideoTrack::id() const { return id_; }
323 323
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 return WebRtcAudioCapturer::CreateCapturer(-1, device_info, constraints, NULL, 531 return WebRtcAudioCapturer::CreateCapturer(-1, device_info, constraints, NULL,
532 audio_source); 532 audio_source);
533 } 533 }
534 534
535 void MockPeerConnectionDependencyFactory::StartLocalAudioTrack( 535 void MockPeerConnectionDependencyFactory::StartLocalAudioTrack(
536 WebRtcLocalAudioTrack* audio_track) { 536 WebRtcLocalAudioTrack* audio_track) {
537 audio_track->Start(); 537 audio_track->Start();
538 } 538 }
539 539
540 } // namespace content 540 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698