Issue 16424004: google_apis: Rename base_operations.h/cc to base_requests.h/cc

Issue 16424004: google_apis: Rename base_operations.h/cc to base_requests.h/cc (Closed)

Created:
7 years, 6 months ago by satorux1

Modified:
7 years, 6 months ago

Reviewers:
Lei Zhang, kinaba

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

google_apis: Rename base_operations.h/cc to base_requests.h/cc The term "operation" is rather a misnomer as these classes are used to issue HTTP requests, hence "request" is a better name. BUG=240599 TEST=none R=kinaba@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204411

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+442 lines, -2077 lines)			Patch
M	chrome/browser/google_apis/auth_service_interface.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/google_apis/base_operations.h	View	1 chunk	+0 lines, -551 lines	0 comments	Download
D	chrome/browser/google_apis/base_operations.cc	View	1 chunk	+0 lines, -773 lines	0 comments	Download
D	chrome/browser/google_apis/base_operations_server_unittest.cc	View	1 chunk	+0 lines, -155 lines	0 comments	Download
D	chrome/browser/google_apis/base_operations_unittest.cc	View	1 chunk	+0 lines, -157 lines	0 comments	Download
A +	chrome/browser/google_apis/base_requests.h	View	19 chunks	+100 lines, -99 lines	0 comments	Download
A +	chrome/browser/google_apis/base_requests.cc	View	27 chunks	+113 lines, -113 lines	0 comments	Download
A +	chrome/browser/google_apis/base_requests_server_unittest.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
A +	chrome/browser/google_apis/base_requests_unittest.cc	View	4 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_operations.h	View	33 chunks	+40 lines, -40 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_operations.cc	View	19 chunks	+44 lines, -44 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_service.cc	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/google_apis/drive_service_interface.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google_apis/gdata_contacts_operations.h	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_contacts_operations.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_operations.h	View	31 chunks	+37 lines, -37 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_operations.cc	View	17 chunks	+41 lines, -41 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_operations_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_service.cc	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/google_apis/operation_runner.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/google_apis/operation_runner.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

satorux1

7 years, 6 months ago (2013-06-06 03:50:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r204411 (presubmit successful).

Expand Messages | Collapse Messages