Auto-sandboxing: add support for a few missing ARM opcodes

Auto-sandboxing: add support for a few missing ARM opcodes

This includes dmb, which counts as a memory operation but the
instruction has no memory operands, and v{ld,st}mia flavors, which were
just left out of the switch table.

R=phosek@chromium.org, jfb@chromium.org
BUG=none

Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/a7e65db52f80831dd4b5cdfa5e7d9b060f8d632d

[Derek Schuff, 2016-01-29 00:43:58]

I forgot that try-git-change no longer works. Guess youll just have to take my
word for it that this works!

[Petr Hosek, 2016-01-29 02:35:07]

lgtm, this seems to be working; I hit more bugs in ARM auto-sandboxing but those
should be probably handled in a separate change.

[JF, 2016-01-29 10:49:51]

I would rewrite dmb sy to dmb ish. Otherwise looks good.

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Derek Schuff, 2016-01-29 16:45:02]

On 2016/01/29 10:49:51, JF wrote:
> I would rewrite dmb sy to dmb ish. Otherwise looks good.
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:native-client-reviews+unsubscribe@googlegroups.com.
> To post to this group, send email to
mailto:native-client-reviews@googlegroups.com.
> Visit this group at https://groups.google.com/group/native-client-reviews.
> For more options, visit https://groups.google.com/d/optout.

If I read the validator source correctly, all the defined argument values are
allowed. Am I wrong about that?

[Derek Schuff, 2016-01-29 16:51:38]

Description was changed from

==========
Auto-sandboxing: add support for a few missing ARM opcodes

This includes dmb, which counts as a memory operation but the
instruction has no memory operands, and v{ld,st}mia flavors, which were
just left out of the switch table.

R=phosek@chromium.org, jfb@chromium.org
BUG=none
==========

to

==========
Auto-sandboxing: add support for a few missing ARM opcodes

This includes dmb, which counts as a memory operation but the
instruction has no memory operands, and v{ld,st}mia flavors, which were
just left out of the switch table.

R=phosek@chromium.org, jfb@chromium.org
BUG=none

Committed:
https://chromium.googlesource.com/native_client/pnacl-llvm/+/a7e65db52f80831d...
==========

[Derek Schuff, 2016-01-29 16:51:39]

Committed patchset #2 (id:20001) manually as
a7e65db52f80831dd4b5cdfa5e7d9b060f8d632d (presubmit successful).

[Derek Schuff, 2016-01-29 16:54:57]

On 2016/01/29 16:45:02, Derek Schuff wrote:
> On 2016/01/29 10:49:51, JF wrote:
> > I would rewrite dmb sy to dmb ish. Otherwise looks good.
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Native-Client-Reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:native-client-reviews+unsubscribe@googlegroups.com.
> > To post to this group, send email to
> mailto:native-client-reviews@googlegroups.com.
> > Visit this group at https://groups.google.com/group/native-client-reviews.
> > For more options, visit https://groups.google.com/d/optout.
> 
> If I read the validator source correctly, all the defined argument values are
> allowed. Am I wrong about that?

Landing this to unblock Petr, we can talk about rewriting dmb. If sy is valid,
I'm not sure we should rewrite it. Does it require special permissions?

[JF, 2016-01-29 18:28:37]

It's just not useful in NaCl. We allowed it because compilers emit it, but
using sy instead of ish doesn't synchronize anything more that the NaCl
sandbox can interact with so it's slow for no reason.

Agreed this can be a separate patch :-)

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.