[Chromecast] Log sample rate changes and tweak audio logging output.

[Chromecast] Log sample rate changes and tweak audio logging output.

Also fixed up some cpplint warnings in
chromecast/base/device_capabilities_impl{.h,_unittest.cc}

BUG=NONE
TEST=Built and ran code; cast_base_unittests

Committed: https://crrev.com/bdd95f17186e06c9920d241a1611773cdafb4914
Cr-Commit-Position: refs/heads/master@{#372244}

[jyw, 2016-01-28 23:18:33]

Description was changed from

==========
[Chromecast] Log sample rate changes and tweak audio logging output.

Also fixed up some cpplint warnings in
chromecast/base/device_capabilities_impl{.h,_unittest.cc}

BUG=NONE
TEST=Built and ran code; cast_base_unittests
==========

to

==========
[Chromecast] Log sample rate changes and tweak audio logging output.

Also fixed up some cpplint warnings in
chromecast/base/device_capabilities_impl{.h,_unittest.cc}

BUG=NONE
TEST=Built and ran code; cast_base_unittests
==========

[jyw, 2016-01-28 23:18:33]

jyw@chromium.org changed reviewers:
+ esum@chromium.org, halliwell@chromium.org, kmackay@chromium.org

[kmackay, 2016-01-28 23:25:41]

https://codereview.chromium.org/1642143003/diff/1/chromecast/media/cma/backen...
File chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc (right):

https://codereview.chromium.org/1642143003/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc:350: LOG(INFO) << "Sample
rate changed from " << output_samples_per_second_
Seems like this should be moved up above the line where
output_samples_per_second_ is set to the new value.

[esum, 2016-01-28 23:29:34]

DeviceCapabilities changes lgtm

[jyw, 2016-01-28 23:39:22]

https://codereview.chromium.org/1642143003/diff/1/chromecast/media/cma/backen...
File chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc (right):

https://codereview.chromium.org/1642143003/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc:350: LOG(INFO) << "Sample
rate changed from " << output_samples_per_second_
On 2016/01/28 23:25:41, kmackay wrote:
> Seems like this should be moved up above the line where
> output_samples_per_second_ is set to the new value.

Done.

[kmackay, 2016-01-28 23:43:41]

lgtm

[halliwell, 2016-01-29 01:20:35]

On 2016/01/28 23:43:41, kmackay wrote:
> lgtm

lgtm

[jyw, 2016-01-29 01:21:47]

The CQ bit was checked by jyw@chromium.org

[jyw, 2016-01-29 01:21:47]

The patchset sent to the CQ was uploaded after l-g-t-m from esum@chromium.org
Link to the patchset: https://codereview.chromium.org/1642143003/#ps20001
(title: "sample rate logging fix")

[commit-bot: I haz the power, 2016-01-29 01:23:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1642143003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1642143003/20001

[commit-bot: I haz the power, 2016-01-29 01:45:00]

Description was changed from

==========
[Chromecast] Log sample rate changes and tweak audio logging output.

Also fixed up some cpplint warnings in
chromecast/base/device_capabilities_impl{.h,_unittest.cc}

BUG=NONE
TEST=Built and ran code; cast_base_unittests
==========

to

==========
[Chromecast] Log sample rate changes and tweak audio logging output.

Also fixed up some cpplint warnings in
chromecast/base/device_capabilities_impl{.h,_unittest.cc}

BUG=NONE
TEST=Built and ran code; cast_base_unittests
==========

[commit-bot: I haz the power, 2016-01-29 01:45:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-29 01:46:30]

Description was changed from

==========
[Chromecast] Log sample rate changes and tweak audio logging output.

Also fixed up some cpplint warnings in
chromecast/base/device_capabilities_impl{.h,_unittest.cc}

BUG=NONE
TEST=Built and ran code; cast_base_unittests
==========

to

==========
[Chromecast] Log sample rate changes and tweak audio logging output.

Also fixed up some cpplint warnings in
chromecast/base/device_capabilities_impl{.h,_unittest.cc}

BUG=NONE
TEST=Built and ran code; cast_base_unittests

Committed: https://crrev.com/bdd95f17186e06c9920d241a1611773cdafb4914
Cr-Commit-Position: refs/heads/master@{#372244}
==========

[commit-bot: I haz the power, 2016-01-29 01:46:32]

Patchset 2 (id:??) landed as
https://crrev.com/bdd95f17186e06c9920d241a1611773cdafb4914
Cr-Commit-Position: refs/heads/master@{#372244}