Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9818)

Unified Diff: chromecast/base/device_capabilities_impl_unittest.cc

Issue 1642143003: [Chromecast] Log sample rate changes and tweak audio logging output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: sample rate logging fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/base/device_capabilities_impl.h ('k') | chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/base/device_capabilities_impl_unittest.cc
diff --git a/chromecast/base/device_capabilities_impl_unittest.cc b/chromecast/base/device_capabilities_impl_unittest.cc
index c1889fc5d9782b55d9674bbde95eff66961b3ef2..999e89964375df680508a3da487683de8153ecc9 100644
--- a/chromecast/base/device_capabilities_impl_unittest.cc
+++ b/chromecast/base/device_capabilities_impl_unittest.cc
@@ -56,7 +56,7 @@ class FakeCapabilityManagerSimple : public DeviceCapabilities::Validator {
void Validate(const std::string& path,
scoped_ptr<base::Value> proposed_value) override {
- ASSERT_TRUE(path.find(key_) == 0);
+ ASSERT_EQ(path.find(key_), 0ul);
if (accept_changes_)
SetValidatedValue(path, std::move(proposed_value));
}
@@ -95,7 +95,7 @@ class FakeCapabilityManagerComplex : public DeviceCapabilities::Validator {
// OnCapabilitiesChanged() without encountering deadlocks/unexpected behavior.
class FakeCapabilitiesObserver : public DeviceCapabilities::Observer {
public:
- FakeCapabilitiesObserver(DeviceCapabilities* capabilities)
+ explicit FakeCapabilitiesObserver(DeviceCapabilities* capabilities)
: capabilities_(capabilities), removed_as_observer(false) {
capabilities_->AddCapabilitiesObserver(this);
}
« no previous file with comments | « chromecast/base/device_capabilities_impl.h ('k') | chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698