Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3829)

Unified Diff: chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc

Issue 1642143003: [Chromecast] Log sample rate changes and tweak audio logging output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: sample rate logging fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc
diff --git a/chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc b/chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc
index ef2ba7c3e5e112944fc5b967ad3ba23c354c773f..0a0ab98354a443d18836483c55e1d7c224459d1a 100644
--- a/chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc
+++ b/chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc
@@ -230,7 +230,8 @@ AudioDecoderAlsa::RenderingDelay AudioDecoderAlsa::GetRenderingDelay() {
void AudioDecoderAlsa::OnDecoderInitialized(bool success) {
TRACE_FUNCTION_ENTRY0();
DCHECK(task_runner_->BelongsToCurrentThread());
- LOG(INFO) << "Decoder initialization returned with success = " << success;
+ LOG(INFO) << "Decoder initialization was "
+ << (success ? "successful" : "unsuccessful");
if (!success)
delegate_->OnDecoderError();
}
@@ -289,7 +290,8 @@ void AudioDecoderAlsa::OnWritePcmCompletion(BufferStatus status,
void AudioDecoderAlsa::OnMixerError() {
TRACE_FUNCTION_ENTRY0();
DCHECK(task_runner_->BelongsToCurrentThread());
- LOG(ERROR) << "Mixer error occured.";
+ // TODO(jyw): properly avoid outputting this message when it isn't needed
+ LOG(ERROR) << "Mixer error occurred. Did the sample rate just change?";
error_ = true;
delegate_->OnDecoderError();
}
« no previous file with comments | « chromecast/base/device_capabilities_impl_unittest.cc ('k') | chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698