Issue 164183010: Revert 251411 "Revert 251054 "Make all the files mapped in when ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164183010: Revert 251411 "Revert 251054 "Make all the files mapped in when ..." (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)

Modified:
6 years, 10 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 251411 "Revert 251054 "Make all the files mapped in when ..." Apparently, couldn't be the cause. Reverting my revert. > Revert 251054 "Make all the files mapped in when running unit_te..." > > Speculative revert, to see if this fixes CrOS MergeSession tests. > > > Make all the files mapped in when running unit_tests read only on Linux and OSX. > > > > This means no file can be opened for write during the test run. > > > > Windows can't be done at the moment due to bug 342913. > > > > R=vadimsh@chromium.org > > BUG=116251 > > BUG=342913 > > > > Review URL: https://codereview.chromium.org/136973003 > > TBR=maruel@chromium.org > > Review URL: https://codereview.chromium.org/166483006 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251426

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	trunk/src/chrome/unit_tests.isolate	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Alexei Svitkine (slow)

6 years, 10 months ago (2014-02-14 21:25:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r251426 (tree was closed).