Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 166483006: Revert 251054 "Make all the files mapped in when running unit_te..." (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)
Modified:
6 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 251054 "Make all the files mapped in when running unit_te..." Speculative revert, to see if this fixes CrOS MergeSession tests. > Make all the files mapped in when running unit_tests read only on Linux and OSX. > > This means no file can be opened for write during the test run. > > Windows can't be done at the moment due to bug 342913. > > R=vadimsh@chromium.org > BUG=116251 > BUG=342913 > > Review URL: https://codereview.chromium.org/136973003 TBR=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
trunk/src/chrome/unit_tests.isolate View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexei Svitkine (slow)
6 years, 10 months ago (2014-02-14 20:31:39 UTC) #1
Alexei Svitkine (slow)
6 years, 10 months ago (2014-02-14 20:31:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r251411.

Powered by Google App Engine
This is Rietveld 408576698