Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 136973003: Make all the files mapped in when running unit_tests read only on Linux and OSX. (Closed)

Created:
6 years, 11 months ago by M-A Ruel
Modified:
6 years, 10 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews
Visibility:
Public.

Description

Make all the files mapped in when running unit_tests read only on Linux and OSX. This means no file can be opened for write during the test run. Windows can't be done at the moment due to bug 342913. R=vadimsh@chromium.org BUG=116251 BUG=342913 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251054

Patch Set 1 #

Patch Set 2 : Rebase properly, disable on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/unit_tests.isolate View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
Same caveats applies than for net_unittests.
6 years, 11 months ago (2014-01-15 19:02:59 UTC) #1
Vadim Sh.
lgtm
6 years, 11 months ago (2014-01-15 19:06:17 UTC) #2
M-A Ruel
On 2014/01/15 19:06:17, Vadim Sh. wrote: > lgtm I decided to not do it on ...
6 years, 10 months ago (2014-02-13 13:44:57 UTC) #3
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 10 months ago (2014-02-13 13:45:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/136973003/260001
6 years, 10 months ago (2014-02-13 13:45:20 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 16:28:02 UTC) #6
Message was sent while issue was closed.
Change committed as 251054

Powered by Google App Engine
This is Rietveld 408576698