Make PaintLayerClipper objects transient

Make PaintLayerClipper objects transient

By storing the cache into PaintLayer, we can avoid PaintLayer::m_clipper
and reduce 2 pointers to 1 pointers in PaintLayer for the clipper.

BUG=581124
Committed: https://crrev.com/aa9d498423426227383460f5e102df4f33b7d2ba
Cr-Commit-Position: refs/heads/master@{#372162}

[Xianzhu, 2016-01-27 20:44:23]

Description was changed from

==========
Make PaintLayerClipper objects transient

By storing the cache into PaintLayer, we can avoid PaintLayer::m_clipper
and reduce 2 pointers to 1 pointers in PaintLayer.

BUG=581124
==========

to

==========
Make PaintLayerClipper objects transient

By storing the cache into PaintLayer, we can avoid PaintLayer::m_clipper
and reduce 2 pointers to 1 pointers in PaintLayer for the clipper.

BUG=581124
==========

[Xianzhu, 2016-01-27 20:44:51]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[chrishtr, 2016-01-27 21:00:34]

https://codereview.chromium.org/1640843003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/1640843003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:97:
PaintLayerClipper::PaintLayerClipper(const PaintLayer& layer)
Inline this just in case?

https://codereview.chromium.org/1640843003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:221: ||
(layoutObject.styleRef().containsPaint() && layoutObject.isBox())) {
How do you know styleRef() is now safe?

[Xianzhu, 2016-01-27 21:54:27]

https://codereview.chromium.org/1640843003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/1640843003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:97:
PaintLayerClipper::PaintLayerClipper(const PaintLayer& layer)
On 2016/01/27 21:00:34, chrishtr wrote:
> Inline this just in case?

Done.

https://codereview.chromium.org/1640843003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:221: ||
(layoutObject.styleRef().containsPaint() && layoutObject.isBox())) {
On 2016/01/27 21:00:34, chrishtr wrote:
> How do you know styleRef() is now safe?

"m_layoutObject.style()->" is equivalent to "m_layoutObject.styleRef()." and it
was safe.

[chrishtr, 2016-01-27 21:56:12]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-01-27 21:56:12]

lgtm

[commit-bot: I haz the power, 2016-01-27 21:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 21:57:39]

This CL has an open dependency (Issue 1636563003 Patch 120001). Please resolve
the dependency and try again.

[Xianzhu, 2016-01-28 19:45:01]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-01-28 19:46:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640843003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640843003/20001

[commit-bot: I haz the power, 2016-01-28 20:57:03]

Description was changed from

==========
Make PaintLayerClipper objects transient

By storing the cache into PaintLayer, we can avoid PaintLayer::m_clipper
and reduce 2 pointers to 1 pointers in PaintLayer for the clipper.

BUG=581124
==========

to

==========
Make PaintLayerClipper objects transient

By storing the cache into PaintLayer, we can avoid PaintLayer::m_clipper
and reduce 2 pointers to 1 pointers in PaintLayer for the clipper.

BUG=581124
==========

[commit-bot: I haz the power, 2016-01-28 20:57:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 20:57:59]

Description was changed from

==========
Make PaintLayerClipper objects transient

By storing the cache into PaintLayer, we can avoid PaintLayer::m_clipper
and reduce 2 pointers to 1 pointers in PaintLayer for the clipper.

BUG=581124
==========

to

==========
Make PaintLayerClipper objects transient

By storing the cache into PaintLayer, we can avoid PaintLayer::m_clipper
and reduce 2 pointers to 1 pointers in PaintLayer for the clipper.

BUG=581124

Committed: https://crrev.com/aa9d498423426227383460f5e102df4f33b7d2ba
Cr-Commit-Position: refs/heads/master@{#372162}
==========

[commit-bot: I haz the power, 2016-01-28 20:58:00]

Patchset 2 (id:??) landed as
https://crrev.com/aa9d498423426227383460f5e102df4f33b7d2ba
Cr-Commit-Position: refs/heads/master@{#372162}