Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 164013002: Revert 230235 "Use BaseShellDialog for print dialog on Windows" (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 230235 "Use BaseShellDialog for print dialog on Windows" Per discussion with ananta, opening a system modal dialog from a background thread is a bad idea, so reverting this (from long ago). Windows doesn't preserve the order correctly when the window is not on the main UI thread, and in the bug here, it interacts very badly with the IME toolbar window, causing the modal print dialog to go behind the browser window in Z order making chrome appear to be hung. The original goal was to fix tasks not being dispatched while the dialog was open. We can instead use the ScopedNestedTaskAllower as we've done for other system modal dialogs which I'll do in a separate CL. BUG=342697, 180997 > Use BaseShellDialog for print dialog on Windows > > This puts the print dialog on a background thread which is necessary so other > top level windows can keep painting as Aura does the compositor swaps on the > UI thread. > > R=sky@chromium.org,vitalybuka@chromium.org > > > Review URL: https://codereview.chromium.org/27441003 TBR=scottmg@chromium.org,sky@chromium.org,vitalybuka@chromium.org,ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -196 lines) Patch
M trunk/src/printing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/printing/printing.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/printing/printing_context_win.h View 3 chunks +1 line, -14 lines 0 comments Download
M trunk/src/printing/printing_context_win.cc View 3 chunks +22 lines, -36 lines 0 comments Download
M trunk/src/ui/shell_dialogs/base_shell_dialog_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
D trunk/src/ui/shell_dialogs/print_settings_dialog_win.h View 1 chunk +0 lines, -83 lines 0 comments Download
D trunk/src/ui/shell_dialogs/print_settings_dialog_win.cc View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
6 years, 10 months ago (2014-02-13 17:02:45 UTC) #1
scottmg
6 years, 10 months ago (2014-02-13 17:02:46 UTC) #2
scottmg
Committed patchset #1 manually as r251066.
6 years, 10 months ago (2014-02-13 17:04:34 UTC) #3
Vitaly Buka (NO REVIEWS)
6 years, 10 months ago (2014-02-13 18:20:41 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698