Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/ui/shell_dialogs/base_shell_dialog_win.cc

Issue 164013002: Revert 230235 "Use BaseShellDialog for print dialog on Windows" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/printing/printing_context_win.cc ('k') | trunk/src/ui/shell_dialogs/print_settings_dialog_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ui/shell_dialogs/base_shell_dialog_win.cc
===================================================================
--- trunk/src/ui/shell_dialogs/base_shell_dialog_win.cc (revision 251065)
+++ trunk/src/ui/shell_dialogs/base_shell_dialog_win.cc (working copy)
@@ -30,9 +30,7 @@
DCHECK(!IsRunningDialogForOwner(owner));
// The owner must be a top level window, otherwise we could end up with two
// entries in our map for the same top level window.
- // TODO(scottmg): This should be re-enabled when Chrome Frame is removed.
- // http://crbug.com/310264
- // DCHECK(!owner || owner == GetAncestor(owner, GA_ROOT));
+ DCHECK(!owner || owner == GetAncestor(owner, GA_ROOT));
RunState run_state;
run_state.dialog_thread = CreateDialogThread();
run_state.owner = owner;
« no previous file with comments | « trunk/src/printing/printing_context_win.cc ('k') | trunk/src/ui/shell_dialogs/print_settings_dialog_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698