Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 27441003: Use BaseShellDialog for print dialog on Windows (Closed)

Created:
7 years, 2 months ago by scottmg
Modified:
7 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use BaseShellDialog for print dialog on Windows This puts the print dialog on a background thread which is necessary so other top level windows can keep painting as Aura does the compositor swaps on the UI thread. R=sky@chromium.org,vitalybuka@chromium.org BUG=180997 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230235

Patch Set 1 #

Patch Set 2 : . #

Total comments: 12

Patch Set 3 : review fixes #

Patch Set 4 : . #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -24 lines) Patch
M printing/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_win.h View 1 2 3 chunks +14 lines, -1 line 0 comments Download
M printing/printing_context_win.cc View 1 3 chunks +36 lines, -22 lines 0 comments Download
M ui/shell_dialogs.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/shell_dialogs/base_shell_dialog_win.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
A ui/shell_dialogs/print_settings_dialog_win.h View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A ui/shell_dialogs/print_settings_dialog_win.cc View 1 2 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
scottmg
vitalybuka: printing/ sky: ui/
7 years, 2 months ago (2013-10-16 03:19:28 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 2 months ago (2013-10-16 04:38:39 UTC) #2
sky
https://codereview.chromium.org/27441003/diff/9001/ui/shell_dialogs/print_settings_dialog_win.h File ui/shell_dialogs/print_settings_dialog_win.h (right): https://codereview.chromium.org/27441003/diff/9001/ui/shell_dialogs/print_settings_dialog_win.h#newcode26 ui/shell_dialogs/print_settings_dialog_win.h:26: class SHELL_DIALOGS_EXPORT Listener { We generally use Observer. https://codereview.chromium.org/27441003/diff/9001/ui/shell_dialogs/print_settings_dialog_win.h#newcode30 ...
7 years, 2 months ago (2013-10-16 14:16:32 UTC) #3
scottmg
thanks https://codereview.chromium.org/27441003/diff/9001/ui/shell_dialogs/print_settings_dialog_win.h File ui/shell_dialogs/print_settings_dialog_win.h (right): https://codereview.chromium.org/27441003/diff/9001/ui/shell_dialogs/print_settings_dialog_win.h#newcode26 ui/shell_dialogs/print_settings_dialog_win.h:26: class SHELL_DIALOGS_EXPORT Listener { On 2013/10/16 14:16:32, sky ...
7 years, 2 months ago (2013-10-16 16:06:20 UTC) #4
sky
LGTM
7 years, 2 months ago (2013-10-16 20:01:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27441003/15001
7 years, 2 months ago (2013-10-16 20:03:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27441003/15001
7 years, 2 months ago (2013-10-16 21:59:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27441003/15001
7 years, 2 months ago (2013-10-17 01:56:18 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=165267
7 years, 2 months ago (2013-10-17 06:39:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27441003/15001
7 years, 2 months ago (2013-10-17 17:18:49 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=210260
7 years, 2 months ago (2013-10-18 00:35:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27441003/15001
7 years, 2 months ago (2013-10-18 02:37:48 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=210572
7 years, 2 months ago (2013-10-18 19:42:32 UTC) #13
scottmg
On 2013/10/18 19:42:32, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 2 months ago (2013-10-18 23:21:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27441003/15001
7 years, 2 months ago (2013-10-18 23:57:46 UTC) #15
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-19 00:36:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27441003/15001
7 years, 2 months ago (2013-10-21 03:17:16 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=211206
7 years, 2 months ago (2013-10-21 06:44:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27441003/395001
7 years, 2 months ago (2013-10-22 20:04:22 UTC) #19
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 22:44:01 UTC) #20
Message was sent while issue was closed. 
Change committed as 230235

Powered by Google App Engine
This is Rietveld 408576698