Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc

Issue 1639663003: Clean up rewrite_to_chrome_style naming logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More comprehensive fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc
index 869d1c434bac0dd0de7ac19f37115303fca1a626..51d6f97bd36571f066e579998392a10533b43092 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc
@@ -9,7 +9,24 @@ int frame_count = 0;
// Make sure that underscore-insertion doesn't get too confused by acronyms.
static int variable_mentioning_http_and_https = 1;
// Already Google style, should not change.
-int already_google_style_;
+int already_google_style;
+// Should still get normalized.
+int goofily_named_variable_for_fun;
+// "A" should be considered its own word.
+int nth_a_value;
+// "V8" and "Data" should be distinct words.
+int my_v8_data;
+// "UTF8" and "Data" should be distinct words.
+int my_utf8_data;
+// "Latin1" and "Data" should be distinct words.
+int my_latin1_data;
+// Identifiers that are all the same case should just be split by underscore,
+// aka assume the human knows what they're doing.
+int gl_compressed_rgb_pvrtc_4bppv1_img;
+int gl_compressed_rgb_s3tc_dxt1_ext;
+// Weird edge cases.
+int my_data_from_utf8_masking_top8_bits;
+bool enable_unsafe_es3_ap_is;
danakj 2016/01/27 00:28:56 itym es3_apis D:
dcheng 2016/01/27 00:38:29 Yeah... previously, this didn't really show up, si
danakj 2016/01/27 00:40:53 that'd be fine.
// Function parameters
int Function(int interesting_number) {

Powered by Google App Engine
This is Rietveld 408576698