Clean up rewrite_to_chrome_style naming logic.

tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 namespace blink {
 
 // Global variables
 int frame_count = 0;
 // Make sure that underscore-insertion doesn't get too confused by acronyms.
 static int variable_mentioning_http_and_https = 1;
 // Already Google style, should not change.
-int already_google_style_;
+int already_google_style;
+// Should still get normalized.
+int goofily_named_variable_for_fun;
+// "A" should be considered its own word.
+int nth_a_value;
+// "V8" and "Data" should be distinct words.
+int my_v8_data;
+// "UTF8" and "Data" should be distinct words.
+int my_utf8_data;
+// "Latin1" and "Data" should be distinct words.
+int my_latin1_data;
+// Identifiers that are all the same case should just be split by underscore,
+// aka assume the human knows what they're doing.
+int gl_compressed_rgb_pvrtc_4bppv1_img;
+int gl_compressed_rgb_s3tc_dxt1_ext;
+// Weird edge cases.
+int my_data_from_utf8_masking_top8_bits;
+bool enable_unsafe_es3_ap_is;

[danakj, 2016/01/27 00:28:56]

itym es3_apis D:

[dcheng, 2016/01/27 00:38:29]

Yeah... previously, this didn't really show up, since we didn't try to fix the
casing on acronyms.

Depending on how many spectacular failures like this there are, I'm thinking of
just special-casing them in the tool in a followup. WDYT?

[danakj, 2016/01/27 00:40:53]

that'd be fine.

 
 // Function parameters
 int Function(int interesting_number) {
   // Local variables.
   int a_local_variable = 1;
   // Static locals.
   static int a_static_local_variable = 2;
   // Make sure references to variables are also rewritten.
   return frame_count +
          variable_mentioning_http_and_https * interesting_number /
              a_local_variable % a_static_local_variable;
 }
 
 }  // namespace blink
 
 int F() {
   // Make sure variables qualified with a namespace name are still rewritten
   // correctly.
   return blink::frame_count;
 }