Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/variables-original.cc

Issue 1639663003: Clean up rewrite_to_chrome_style naming logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More comprehensive fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/variables-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/variables-original.cc b/tools/clang/rewrite_to_chrome_style/tests/variables-original.cc
index 5ae1dbc5f274d0f8a53a9bd67982dc774ad52c95..cf680fc409766c60684c742c658e72e8139ef955 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/variables-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/variables-original.cc
@@ -10,6 +10,23 @@ int frameCount = 0;
static int variableMentioningHTTPAndHTTPS = 1;
// Already Google style, should not change.
int already_google_style_;
+// Should still get normalized.
+int Goofily_named_VARIABLE_for_FUN_;
+// "A" should be considered its own word.
+int nthAValue;
+// "V8" and "Data" should be distinct words.
+int myV8Data;
+// "UTF8" and "Data" should be distinct words.
+int myUTF8Data;
+// "Latin1" and "Data" should be distinct words.
+int myLatin1Data;
+// Identifiers that are all the same case should just be split by underscore,
+// aka assume the human knows what they're doing.
+int GL_COMPRESSED_RGB_PVRTC_4BPPV1_IMG;
+int GL_COMPRESSED_RGB_S3TC_DXT1_EXT;
+// Weird edge cases.
+int myDataFromUTF8MaskingTop8Bits;
+bool enableUnsafeES3APIs;
// Function parameters
int function(int interestingNumber) {

Powered by Google App Engine
This is Rietveld 408576698