Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 163953012: Notification settings for ephemeral apps (Closed)

Created:
6 years, 10 months ago by tmdiep
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Notification settings for ephemeral apps Only running ephemeral apps will appear in the notification settings pane. This avoids spamming the list with inactive cached ephemeral apps. The setting will also be persisted across cache evictions, so that notifications will still be disabled when the ephemeral app is re-cached at a later date. BUG=343453 TEST=browser_tests (EphemeralAppBrowserTest.StickyNotificationSettings) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251754

Patch Set 1 #

Patch Set 2 : Added test for MessageCenterSettingsController::GetNotifierList #

Patch Set 3 : Abort test for linux gtk #

Messages

Total messages: 10 (0 generated)
tmdiep
dewittj: for notifications. koz: for apps. Please review this patch. Thanks. A question for dewittj ...
6 years, 10 months ago (2014-02-14 02:27:47 UTC) #1
dewittj
On 2014/02/14 02:27:47, tmdiep wrote: > dewittj: for notifications. > koz: for apps. > Please ...
6 years, 10 months ago (2014-02-14 22:43:56 UTC) #2
dewittj
notifications lgtm
6 years, 10 months ago (2014-02-14 22:45:34 UTC) #3
dewittj
On 2014/02/14 22:45:34, dewittj wrote: > notifications lgtm Please, add some tests for the notification ...
6 years, 10 months ago (2014-02-14 22:45:59 UTC) #4
koz (OOO until 15th September)
apps lgtm
6 years, 10 months ago (2014-02-17 00:20:02 UTC) #5
tmdiep
On 2014/02/14 22:45:59, dewittj wrote: > Please, add some tests for the notification service/message center ...
6 years, 10 months ago (2014-02-17 05:46:05 UTC) #6
koz (OOO until 15th September)
On 2014/02/17 05:46:05, tmdiep wrote: > On 2014/02/14 22:45:59, dewittj wrote: > > Please, add ...
6 years, 10 months ago (2014-02-17 22:47:45 UTC) #7
tmdiep
The CQ bit was checked by tmdiep@chromium.org
6 years, 10 months ago (2014-02-18 10:41:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/163953012/170001
6 years, 10 months ago (2014-02-18 10:41:19 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 12:44:56 UTC) #10
Message was sent while issue was closed.
Change committed as 251754

Powered by Google App Engine
This is Rietveld 408576698