Notification settings for ephemeral apps

Notification settings for ephemeral apps

Only running ephemeral apps will appear in the notification settings
pane. This avoids spamming the list with inactive cached ephemeral apps.

The setting will also be persisted across cache evictions, so that
notifications will still be disabled when the ephemeral app is
re-cached at a later date.

BUG=343453
TEST=browser_tests (EphemeralAppBrowserTest.StickyNotificationSettings)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251754

[tmdiep, 2014-02-14 02:27:47]

dewittj: for notifications.
koz: for apps.
Please review this patch. Thanks.

A question for dewittj - It seems we don't sync the disabling of notifiers
across devices? Would it be a bad idea to? Please see comments #4 and #5 for
some context.

[dewittj, 2014-02-14 22:43:56]

On 2014/02/14 02:27:47, tmdiep wrote:
> dewittj: for notifications.
> koz: for apps.
> Please review this patch. Thanks.
> 
> A question for dewittj - It seems we don't sync the disabling of notifiers
> across devices? Would it be a bad idea to? Please see comments #4 and #5 for
> some context.

We don't sync notification settings because we expect that users may have
different preferences on different machines.  Hence we allow them to be
configured individually which would be made complicated if sync was constantly
changing the setting every time it was changed.

[dewittj, 2014-02-14 22:45:34]

notifications lgtm

[dewittj, 2014-02-14 22:45:59]

On 2014/02/14 22:45:34, dewittj wrote:
> notifications lgtm

Please, add some tests for the notification service/message center settings
controller to reflect this logic.

[koz (OOO until 15th September), 2014-02-17 00:20:02]

apps lgtm

[tmdiep, 2014-02-17 05:46:05]

On 2014/02/14 22:45:59, dewittj wrote:
> Please, add some tests for the notification service/message center settings
> controller to reflect this logic.

I have added an additional browser test for the change to message center
settings. Both changes are now tested, but located within apps rather than
notifications. Would this be ok?

[koz (OOO until 15th September), 2014-02-17 22:47:45]

On 2014/02/17 05:46:05, tmdiep wrote:
> On 2014/02/14 22:45:59, dewittj wrote:
> > Please, add some tests for the notification service/message center settings
> > controller to reflect this logic.
> 
> I have added an additional browser test for the change to message center
> settings. Both changes are now tested, but located within apps rather than
> notifications. Would this be ok?

apps/ still lgtm

[tmdiep, 2014-02-18 10:41:06]

The CQ bit was checked by tmdiep@chromium.org

[commit-bot: I haz the power, 2014-02-18 10:41:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tmdiep@chromium.org/163953012/170001

[commit-bot: I haz the power, 2014-02-18 12:44:56]

Change committed as 251754