chrome/browser/notifications/desktop_notification_service.cc - Issue 163953012: Notification settings for ephemeral apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 163953012: Notification settings for ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Abort test for linux gtk Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/desktop_notification_service.cc

diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc

index 0f8c738e4cb894f11dbb46f61e26e4869459c50e..9dc9d9824d6b59ce454404c8ffa8e40f8fe73614 100644

--- a/chrome/browser/notifications/desktop_notification_service.cc

+++ b/chrome/browser/notifications/desktop_notification_service.cc

@@ -781,6 +781,10 @@ void DesktopNotificationService::Observe(

if (IsNotifierEnabled(notifier_id))

return;

+ // The settings for ephemeral apps will be persisted across cache evictions.

+ if (extension->is_ephemeral())

+ return;

SetNotifierEnabled(notifier_id, true);

}